Offspring Master shouldn't log errors for builders that are not expected to be running
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Offspring |
Fix Released
|
High
|
Unassigned |
Bug Description
Currently, LexbuilderMaste
This means that when scanning slaves, if a slave was marked as is_active=False it would still be scanned, and so the logs are constantly reporting things like
Wed, 02 Jan 2013 14:56:20 ERROR Scan of olive failed. Socket error: [Errno 113] No route to host
Wed, 02 Jan 2013 14:56:20 ERROR Scan of lexbuild7 failed. Socket error: [Errno -2] Name or service not known
Wed, 02 Jan 2013 14:56:20 ERROR Scan of lexbuild8 failed. Socket error: [Errno -2] Name or service not known
Wed, 02 Jan 2013 14:56:20 ERROR Scan of lexbuild4 failed. Socket error: [Errno -2] Name or service not known
Wed, 02 Jan 2013 14:56:20 ERROR Scan of lexbuild1 failed. Socket error: [Errno -2] Name or service not known
Wed, 02 Jan 2013 14:56:20 ERROR Scan of lexbuild5 failed. Socket error: [Errno -2] Name or service not known
Wed, 02 Jan 2013 14:56:20 ERROR Scan of lexbuild10 failed. Socket error: [Errno -2] Name or service not known
Wed, 02 Jan 2013 14:56:21 ERROR Scan of lexbuild3 failed. Socket error: [Errno -2] Name or service not known
scanSlaves (actually _get_builders) should only scan active slaves.
Related branches
- Offspring Committers: Pending requested
-
Diff: 71 lines (+18/-6)2 files modifiedlib/offspring/master/master.py (+3/-3)
lib/offspring/master/tests/test_master.py (+15/-3)
- David Murphy (community): Needs Information
- Kevin McDermott: Approve
-
Diff: 374 lines (+246/-13)9 files modifiedlib/offspring/master/master.py (+2/-1)
lib/offspring/master/models.py (+1/-0)
lib/offspring/master/tests/helpers.py (+2/-1)
lib/offspring/master/tests/test_master.py (+21/-7)
lib/offspring/web/queuemanager/admin.py (+5/-2)
lib/offspring/web/queuemanager/migrations/0003_auto__add_field_lexbuilder_is_retired.py (+173/-0)
lib/offspring/web/queuemanager/models.py (+1/-0)
lib/offspring/web/queuemanager/tests/test_views.py (+38/-0)
lib/offspring/web/urls.py (+3/-2)
Changed in offspring: | |
importance: | Undecided → Medium |
summary: |
- Offspring Master shouldn't scan slaves not marked as is_active + Offspring Master shouldn't log errors for builders that are not expected + to be running |
Changed in offspring: | |
status: | Triaged → In Progress |
Changed in offspring: | |
status: | In Progress → Fix Committed |
Changed in offspring: | |
status: | Fix Committed → Fix Released |
Scanning inactive slaves is a feature, it helps the admin know whether an inactive slave is available to be put back into service. For example, looking at the builders page I see that monkeyapple is inactive but online (healthy), and ready to be put back into service if necessary.