Support goodix fingerprint [27c6:6582]

[Bin Li]

[27c6:6582] include in https://gitlab.freedesktop.org/libfprint/libfprint/-/merge_requests/447

[Impact]

 * Support goodix [27c6:6582] fingerprint component.

[Test Plan]

 * Find a machine with this fingerprint device

 * Launch `settings` and enable `Fingerprint Login`

 * Enroll finger and then logout

 * Login system with enrolled finger

[Where problems could occur]

 * The patch add new ids to id_table. Should not affect previous supported device.

[Sebastien Bacher (seb128)]

Thanks, by SRU rules we need to upload the fix first to noble and also SRU to lunar and mantic, could you also prepare updates for those series? Lunar also has a previous SRU in proposed currently that needs to be verified

[Andreas Hasenack (ahasenack)]

Marking as incomplete pending the completion of what was requested in comment #2 above. I also added tasks for the missing ubuntu releases.

[Bin Li (binli)]

This is for lunar updates.

[Bin Li (binli)]

This is for mantic and noble updates.

[Bin Li (binli)]

Hi seb128,

 Please continue to handle this. Thanks!

[Brian Murray (brian-murray)]

Ubuntu 23.04 (Lunar Lobster) has reached end of life, so this bug will not be fixed for that specific release.

[Bin Li (binli)]

https://salsa.debian.org/ubuntu-dev-team/libfprint/-/merge_requests/18

[Bin Li (binli)]

After installing the new package libfprint-2-2_1.94.3+tod1-0ubuntu2~22.04.07binli5_amd64.deb, the problem has been fixed. Please see attached files.

  * d/p/goodix-Reset-device-if-storage-listing-fails.patch
    d/p/goodixmoc-Fix-missing-enroll-create-state.patch
    d/p/goodixmoc-cleanup-enroll-state-machine.patch
    d/p/goodixmoc-Add-PID-0x6582.patch (LP: #2042394)

https://launchpad.net/~binli/+archive/ubuntu/ppa/+files/libfprint-2-2_1.94.3+tod1-0ubuntu2~22.04.07binli5_amd64.deb

System: Panther-3
OS: Ubuntu 22.04.4 LTS
Kernel: 6.5.0-1016-oem
FPR: Goodix MOC PID 6582

[Brian Murray (brian-murray)]

Ubuntu 23.10 (Mantic Minotaur) has reached end of life, so this bug will not be fixed for that specific release.

[Bin Li (binli)]

Currently we only add d/p/goodixmoc-Add-PID-0x6582.patch to support this fingerprint.

I reverted the 3 below patches because of potential regression. And it has merged into jammy.

https://salsa.debian.org/ubuntu-dev-team/libfprint/-/merge_requests/21

 d/p/goodix-Reset-device-if-storage-listing-fails.patch
 d/p/goodixmoc-Fix-missing-enroll-create-state.patch
 d/p/goodixmoc-cleanup-enroll-state-machine.patch

And for noble/mantic, the goodixmoc-Add-PID-0x6582.patch has included. So we just need SRU this issue for jammy.

[Timo Aaltonen (tjaalton)]

Hello Bin, or anyone else affected,

Accepted libfprint into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libfprint/1:1.94.3+tod1-0ubuntu2~22.04.08 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Bin Li (binli)]

After installing the new package 1:1.94.3+tod1-0ubuntu2~22.04.08 in proposed, the new device was recognized and could be used.

System: ThinkPad X1 Carbon Gen 11
OS: Ubuntu 22.04.4 LTS
Kernel: 6.5.0-1016-oem
FPR: Goodix MOC PID 6582

[Launchpad Janitor (janitor)]

This bug was fixed in the package libfprint - 1:1.94.3+tod1-0ubuntu2~22.04.08

---------------
libfprint (1:1.94.3+tod1-0ubuntu2~22.04.08) jammy; urgency=medium

  [ Bin Li ]
  * d/p/fpcmoc-Support-FPC-moc-devices.patch (LP: #2054538)
  * d/p/fpcmoc-Ensure-the-current-SSM-is-never-overwritten.patch (LP: #2054538)
  * d/p/fpcmoc-fix-use-after-free-in-multiple-callbacks.patch (LP: #2054538)
  * d/p/goodixmoc-add-PID-0x659A.patch (LP: #2058202)
  * d/p/elanmoc-add-PID-0x0c8c-0x0c8d.patch (LP: #2058013)
  * d/p/goodixmoc-Add-PID-0x6582.patch (LP: #2042394)

  [ Marco Trevisan (Treviño) ]
  * debian/patches: Refresh indexes
  * debian/patches: Fully import fix for synaptics storage-empty fix
    (LP: #2034481)
  * debian/patches/include-binaries: Include explanation of the binary data
  * d/source/include-binaries: Include goodix patch enroll fix
  * debian/libfprint-2-2.postinst: Update the udev triggers for new devices

 -- Marco Trevisan (Treviño) <email address hidden> Wed, 24 Jul 2024 09:00:05 +0200

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for libfprint has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.