Activity log for bug #2035561

Date Who What changed Old value New value Message
2023-09-14 01:34:50 Khairul Aizat Kamarudzzaman bug added bug
2023-09-14 01:43:50 Khairul Aizat Kamarudzzaman attachment added tp-smapi-dkms.0.crash https://bugs.launchpad.net/ubuntu/+source/tp-smapi/+bug/2035561/+attachment/5700727/+files/tp-smapi-dkms.0.crash
2023-11-23 10:27:52 Bin Li summary crash when installing tp-smapi [SRU]crash when installing tp-smapi
2023-11-23 10:30:53 Bin Li bug task added oem-priority
2023-11-23 10:30:59 Bin Li oem-priority: assignee Bin Li (binli)
2023-11-23 10:31:03 Bin Li oem-priority: importance Undecided Critical
2023-11-23 10:31:10 Bin Li oem-priority: status New In Progress
2023-11-23 10:47:36 Bin Li description ~> sudo apt install tp-smapi-dkms [sudo] password for fenris: Reading package lists... Done Building dependency tree... Done Reading state information... Done The following NEW packages will be installed: tp-smapi-dkms 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded. Need to get 0 B/34.0 kB of archives. After this operation, 124 kB of additional disk space will be used. Selecting previously unselected package tp-smapi-dkms. (Reading database ... 313945 files and directories currently installed.) Preparing to unpack .../tp-smapi-dkms_0.43-1ubuntu1_amd64.deb ... Unpacking tp-smapi-dkms (0.43-1ubuntu1) ... Setting up tp-smapi-dkms (0.43-1ubuntu1) ... Loading new tp_smapi-0.43 DKMS files... Building for 6.5.0-5-generic Building initial module for 6.5.0-5-generic ERROR: Cannot create report: [Errno 17] File exists: '/var/crash/tp-smapi-dkms.0.crash' Error! Bad return status for module build on kernel: 6.5.0-5-generic (x86_64) Consult /var/lib/dkms/tp_smapi/0.43/build/make.log for more information. dpkg: error processing package tp-smapi-dkms (--configure): installed tp-smapi-dkms package post-installation script subprocess returned error exit status 10 Errors were encountered while processing: tp-smapi-dkms E: Sub-process /usr/bin/dpkg returned an error code (1) ProblemType: Bug DistroRelease: Ubuntu 23.10 Package: tp-smapi-dkms 0.43-1ubuntu1 ProcVersionSignature: Ubuntu 6.5.0-5.5-generic 6.5.0 Uname: Linux 6.5.0-5-generic x86_64 NonfreeKernelModules: nvidia_modeset nvidia ApportVersion: 2.27.0-0ubuntu2 Architecture: amd64 CasperMD5CheckResult: pass CurrentDesktop: ubuntu:GNOME Date: Thu Sep 14 09:32:45 2023 InstallationDate: Installed on 2023-07-08 (68 days ago) InstallationMedia: Ubuntu 23.10 "Mantic Minotaur" - Daily amd64 (20230705) SourcePackage: tp-smapi UpgradeStatus: No upgrade log present (probably fresh install) [Impact] tp-smapi-dkms is a kernel module exposes some features of the ThinkPad hardware/firmware via a sysfs interface. It will crash after 6.4 kernel. In OEM projects, we met this issue on 6.5.0-oem kernel. And it blocks our QA team to install hdapsd, because it's in "Recommends: tp-smapi-dkms". [Test case] On 22.04, just run below command. $ sudo apt install tp-smapi-dkms Loading new tp_smapi-0.43 DKMS files... Building for 6.5.0-1008-oem Building initial module for 6.5.0-1008-oem ERROR: Cannot create report: [Errno 17] File exists: '/var/crash/tp-smapi-dkms.0.crash' Error! Bad return status for module build on kernel: 6.5.0-1008-oem (x86_64) Consult /var/lib/dkms/tp_smapi/0.43/build/make.log for more information. dpkg: error processing package tp-smapi-dkms (--configure): installed tp-smapi-dkms package post-installation script subprocess returned error exit status 10 Errors were encountered while processing: tp-smapi-dkms E: Sub-process /usr/bin/dpkg returned an error code (1) [Potential regression] It's low risk, cherry-pick from uptream, it uses KERNEL_VERSION MACRO to support 6.4+ kernel. Linux changed the DEFINE_SEMAPHORE macro in 48380368dec14859723b9e3fbd43e042638d9a76, making it take two parameters instead of one. Pass an explicit 1 as on 6.4+. /* Locking: */ #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37) static DECLARE_MUTEX(thinkpad_ec_mutex); -#else +#elif LINUX_VERSION_CODE < KERNEL_VERSION(6,4,0) static DEFINE_SEMAPHORE(thinkpad_ec_mutex); +#else +static DEFINE_SEMAPHORE(thinkpad_ec_mutex, 1); #endif
2023-11-23 10:48:27 Bin Li attachment added 0001-update-DEFINE_SEMAPHORE-usage-for-linux-6.4.patch https://bugs.launchpad.net/oem-priority/+bug/2035561/+attachment/5722676/+files/0001-update-DEFINE_SEMAPHORE-usage-for-linux-6.4.patch
2023-11-23 10:51:34 Bin Li attachment added tp-smapi_0.43-1ubuntu2.debdiff https://bugs.launchpad.net/oem-priority/+bug/2035561/+attachment/5722677/+files/tp-smapi_0.43-1ubuntu2.debdiff
2023-11-23 10:53:34 Bin Li bug added subscriber Ubuntu Sponsors
2023-11-23 10:55:12 Bin Li bug added subscriber Ubuntu Stable Release Updates Team
2023-11-23 10:57:50 Bin Li oem-priority: status In Progress Triaged
2023-11-24 08:00:56 Bin Li attachment removed tp-smapi_0.43-1ubuntu2.debdiff https://bugs.launchpad.net/ubuntu/+source/tp-smapi/+bug/2035561/+attachment/5722677/+files/tp-smapi_0.43-1ubuntu2.debdiff
2023-11-24 08:01:33 Bin Li attachment added tp-smapi_0.43-1ubuntu2.debdiff https://bugs.launchpad.net/ubuntu/+source/tp-smapi/+bug/2035561/+attachment/5722924/+files/tp-smapi_0.43-1ubuntu2.debdiff
2023-11-29 14:39:29 Simon Quigley removed subscriber Ubuntu Sponsors
2024-03-17 20:34:16 Rex Tsai tags amd64 apport-bug mantic wayland-session amd64 apport-bug mantic oem-priority wayland-session