ubiquity crashes by a missing translation string

[Yao Wei]

This is an issue used with dell-recovery on 22.04, where ubiquity can be crashed by missing translation string

'ubiquity/text/label_download_updates'
'ubiquity/text/label_download_updates_na'

when triggering connection or disconnection but the strings are untranslated and returns None

[Yao Wei (medicalwei)]

Excerpt from installer/debug:

Exception in GTK frontend (invoking crash handler):
Traceback (most recent call last):
  File "/usr/lib/ubiquity/ubiquity/frontend/base.py", line 473, in check_returncode
    self.set_online_state(state)
  File "/usr/lib/ubiquity/ubiquity/frontend/gtk_ui.py", line 586, in set_online_state
    p.ui.plugin_set_online_state(state)
  File "/usr/lib/ubiquity/plugins/ubi-prepare.py", line 55, in plugin_set_online_state
    self.enable_download_updates(state)
  File "/usr/lib/ubiquity/plugins/ubi-prepare.py", line 190, in enable_download_updates
    self.label_download_updates.set_label(
TypeError: Argument 1 does not allow None as a value

Traceback (most recent call last):
  File "/usr/lib/ubiquity/ubiquity/frontend/base.py", line 473, in check_returncode
    self.set_online_state(state)
  File "/usr/lib/ubiquity/ubiquity/frontend/gtk_ui.py", line 586, in set_online_state
    p.ui.plugin_set_online_state(state)
  File "/usr/lib/ubiquity/plugins/ubi-prepare.py", line 55, in plugin_set_online_state
    self.enable_download_updates(state)
  File "/usr/lib/ubiquity/plugins/ubi-prepare.py", line 190, in enable_download_updates
    self.label_download_updates.set_label(
TypeError: Argument 1 does not allow None as a value

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "lp1994502.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Simon Chopin (schopin)]

Hi,

Do you know what the locale was that triggered this?

The patch seems rather wrong, as nowhere else in the code do we guard against None values from translation. Looking at the code, it seems that the only way we get a None value is if the label isn't present *at all* which doesn't sound normal?

[Yao Wei (medicalwei)]

It was en_US, but translation files are replaced with files supplied by dell-recovery, which does not include the translation strings. This sounds weird if we support the extensibility that allows oem flow, but requires a translation string that's unused to be in place of the extensions.