[fwupd][SRU] Hide inhibited usb4 device in dell-dock plugin
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
OEM Priority Project | Status tracked in Focal | |||||
Focal |
Fix Released
|
High
|
Kai-Chuan Hsieh | |||
fwupd (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | |||
Focal |
Fix Released
|
Undecided
|
Unassigned | |||
Jammy |
Fix Released
|
Undecided
|
Unassigned | |||
Kinetic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
In fwupd mechanism, a device might be probed by multiple plugins, so an "inhibited flag" might be applied to prevent it been probed several times.
An "Update Error" message will show up once this flag has been applied [0], and this will confuse some users to let they think the firmware upgrade process failed , in the purpose of improving the user experience, a patch has been merged to upstream to hide the inhibited usb4 device[1].
[Impact]
* A new flag "hidden" has been added in the inhibited code snippet, once the device enumeration found this flag, it will not show it.
* Since this misleading message has be hidden, the users won't be confused on the inhibited message.
[Test Plan]
* Prepare a dell-dock wd22tb4.
* Prepare one pc or laptop with thunderbolt interface on it.
* Before(include) fwupd upstream version 1.8.2 or Ubuntu version 1.7.5-3, a "waning message"[0] will be observed on the inhibited device via the command "fwupdmgr get-devices".
* Once this patch has been applied, the inhibited device will be hidden.
[Where problems could occur]
* The only problem might occur is once someone misuses this flag "hidden" when they use this device_inhibit function, then the devices will be hidden.
* But after double confirm, I __do not__ see someone else has applied this flag on their plugin.
[0] https:/
[1] https:/
For other risk and test plan, please check lp:1982103
tags: | added: oem-priority |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
information type: | Proprietary → Public |
tags: | added: focal |
Changed in oem-priority: | |
importance: | Undecided → High |
status: | New → In Progress |
Changed in oem-priority: | |
status: | In Progress → Confirmed |
description: | updated |
tags: | added: fwupd |
tags: | removed: verification-done-jammy verification-needed |
tags: |
added: jammy removed: focal |
Changed in oem-priority: | |
status: | In Progress → Confirmed |
Changed in oem-priority: | |
assignee: | Yuan-Chen Cheng (ycheng-twn) → Kai-Chuan Hsieh (kchsieh) |
no longer affects: | oem-priority/focal |
Changed in fwupd (Ubuntu Jammy): | |
status: | Confirmed → In Progress |
Changed in fwupd (Ubuntu Focal): | |
status: | New → In Progress |
We will also need https:/ /github. com/fwupd/ fwupd/commit/ 6b5d933e99dce7f 2bf2b7711760011 91a3bab644
to be backported to 1.7 branches.
However, that will add a new API to libfwupdplugin, sound not something we should do.