[SRU] Debounce multiple rfkill events

[Kai-Heng Feng]

[Impact]
Some laptops can generate multiple rfkill events from a single key press.

[Fix]
Commit f4dbcf3d7b0f951fe44b29229206c97b625dbfda ("media-keys: Add one second delay between each rfkill event").
The commit adds a delay between each rkfill events to only process the first event and debounce the later ones.

[Test]
On HP ZBook G7, use `libinput debug-events` to observe there are two rfkill events on single key press. Airplane mode will be enabled and disabled in a very short period, so the airplane mode cannot be turned off by the hotkey anymore.

After applying the fix, pressing airplane mode hotkey can enable or disable airplane mode correctly.

[Where problems could occur]
Since the delay is hardcoded as 1 second, the airplane mode cannot be switched on/of in a very short time anymore.

[Andy Chi (andch)]

upload debdiff for focal

[Andy Chi (andch)]

upload debdiff for hitsute

[Andy Chi (andch)]

upload debdiff of impish

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "gnome-settings-daemon_3.36.1-0ubuntu1.2.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-settings-daemon - 40.0.1-1ubuntu2

---------------
gnome-settings-daemon (40.0.1-1ubuntu2) impish; urgency=medium

  * d/p/git-media-keys-Addd-one-second-delay-between-each-rfkill-.patch
    - Add one second dely between each rfkill event (lp: #1936303)

 -- Andy Chi <email address hidden> Fri, 16 Jul 2021 12:09:36 +0200

[Robie Basak (racb)]

Hello Kai-Heng, or anyone else affected,

Accepted gnome-settings-daemon into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-settings-daemon/3.38.1-3ubuntu3.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Robie Basak (racb)]

Hello Kai-Heng, or anyone else affected,

Accepted gnome-settings-daemon into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-settings-daemon/3.36.1-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted gnome-settings-daemon (3.38.1-3ubuntu3.1) for hirsute have finished running.
The following regressions have been reported in tests triggered by the package:

indicator-session/17.3.20+21.04.20210327-0ubuntu1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/hirsute/update_excuses.html#gnome-settings-daemon

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Kai-Heng Feng (kaihengfeng)]

The indicator-session regression doesn't seem to be related to this SRU:
[ FAILED ] 1 test, listed below:
[ FAILED ] Actions.CanHibernate

[Kai-Heng Feng (kaihengfeng)]

Enable -proposed and upgrade G-S-D to 3.36.1-0ubuntu1.1.

Use `sudo libinput debug-events` to monitor input events, press airplane mode hotkey, observe there are two events.

The airplane mode can be toggled on/off despite there are two rfkill events.

[Kai-Heng Feng (kaihengfeng)]

On hirsute, enable -proposed and upgrade G-S-D to 3.38.1-3ubuntu3.1.

Similar to Focal, observed two KEY_RKFILL in `libinput debug-events` on a single airplane hotkey press, but the airplane mode can be toggled on/off correctly.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-settings-daemon - 3.38.1-3ubuntu3.1

---------------
gnome-settings-daemon (3.38.1-3ubuntu3.1) hirsute; urgency=medium

  * d/p/git-rfkill-set-the-g_io_channel-to-unbuffered-mode.patch:
    - Set the g_io_channel to unbuffered mode to fix airplane mode with
      newer kernel versions (lp: #1926062)
  * d/p/git-media-keys-Addd-one-second-delay-between-each-rfkill-.patch
    - Add one second dely between each rfkill event (lp: #1936303)

 -- Andy Chi <email address hidden> Thu, 15 Jul 2021 09:57:58 +0200

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for gnome-settings-daemon has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-settings-daemon - 3.36.1-0ubuntu1.1

---------------
gnome-settings-daemon (3.36.1-0ubuntu1.1) focal; urgency=medium

  * d/p/git-rfkill-set-the-g_io_channel-to-unbuffered-mode.patch:
    - Set the g_io_channel to unbuffered mode to fix airplane mode with
      newer kernel versions (lp: #1926062)
  * d/p/git-media-keys-Addd-one-second-delay-between-each-rfkill-.patch
    - Add one second dely between each rfkill event (lp: #1936303)

 -- Andy Chi <email address hidden> Thu, 08 Jul 2021 17:35:19 +0800