Dell dock USB4 module need fwupd 1.5.11

Bug #1934209 reported by Yuan-Chen Cheng
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Released
Critical
Yuan-Chen Cheng
fwupd (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned
Hirsute
Fix Released
Undecided
Unassigned
Impish
Fix Released
Undecided
Unassigned
fwupd-signed (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned
Hirsute
Fix Released
Undecided
Unassigned
Impish
Fix Released
Undecided
Unassigned

Bug Description

need focal/fwupd 1.5.11 to support this

Ref: https://github.com/fwupd/fwupd/releases/tag/1.5.11

Note: this version shall work well with shim with sbat.
Note: for focal, we also need to upgrade jcat to make it work.

[Impact]

 * We need to support Dell USB4 Dock and based on the fwupd design,
   need to upgrade the version to support it.

 * This new version will also enable certain vendors to upgrade
   intel-microcode by fwupd. Some security updates of intel-microcode
   does introduce regresssion because it's not tested across enough
   CPU family. Vendors can do more tests give they have access to
   those machines and have access to those new microcodes with
   security patches.

 * Will follow the new policy to do this SRU exception.
   https://wiki.ubuntu.com/firmware-updates

[Test Plan]

 * Full standard verification test listed in
   https://wiki.ubuntu.com/firmware-updates

 * Install a sbat enable shim, turned on secure boot and make sure
   the new fwupd firmware upgrade efi still work fine.

 * Will also invite the component vendor to test the new supported
   docking when the new fwupd exists in the proposed channel.
   They already started to use the one in my ppa on focal given
   LTS release is the HWE project target.

[Where problems could occur]

 * If it passed the verification procedure in the policy, I believe
   it shall already cover most cases.

[Other Info]

 * This suppose to fix several bugs. OEM team will test
   those along the way.

information type: Proprietary → Public
summary: - Dell dock USB4 module in fwupd
+ Dell dock USB4 module need fwupd 1.5.11
description: updated
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

The prepared deb lives in this ppa:

https://launchpad.net/~ycheng-twn/+archive/ubuntu/fwupd1511

Please kindly review and test it as convenient.

BTW, given groovy is EOL, I have no plan to prepare SRU for it.

no longer affects: fwupd (Ubuntu Groovy)
no longer affects: fwupd-signed (Ubuntu Groovy)
tags: added: fwupd oem-priority
description: updated
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

for impish deb in the ppa, sbat section is there.

$ objdump -h fwupdx64.efi

fwupdx64.efi: file format pei-x86-64

Sections:
Idx Name Size VMA LMA File off Algn
  0 .text 00007d6b 0000000000004000 0000000000004000 00000400 2**4
                  CONTENTS, ALLOC, LOAD, READONLY, CODE
  1 .reloc 0000000a 000000000000c000 000000000000c000 00008200 2**2
                  CONTENTS, ALLOC, LOAD, READONLY, DATA
  2 .data 00002d68 000000000000d000 000000000000d000 00008400 2**4
                  CONTENTS, ALLOC, LOAD, DATA
  3 .dynamic 00000150 0000000000010000 0000000000010000 0000b200 2**2
                  CONTENTS, ALLOC, LOAD, DATA
  4 .rela 00000e70 0000000000011000 0000000000011000 0000b400 2**2
                  CONTENTS, ALLOC, LOAD, READONLY, DATA
  5 .rela.plt 00000018 0000000000011e70 0000000000011e70 0000c470 2**2
                  CONTENTS, ALLOC, LOAD, READONLY, DATA
  6 .sbat 000000ee 0000000000012000 0000000000012000 0000c800 2**2
                  CONTENTS, ALLOC, LOAD, READONLY, DATA

Changed in oem-priority:
status: Confirmed → In Progress
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

impish fwupd-sign debdiff.

tags: added: sbat
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "fwupd-sign_1.39.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
description: updated
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

It's said 1.5.11 still not complete. Before we got confirm, hold off for now.

Changed in oem-priority:
status: In Progress → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwupd - 1.5.11-0ubuntu1

---------------
fwupd (1.5.11-0ubuntu1) impish; urgency=medium

  * New upstream version (1.5.11) to support Dell dock USB4 module.
    (LP: #1934209)
  * Drop all patches upstream.
  * Sync updated files from contrib/debian/ to debian/.

 -- Yuan-Chen Cheng <email address hidden> Thu, 01 Jul 2021 01:06:11 +0000

Changed in fwupd (Ubuntu Impish):
status: New → Fix Released
Changed in fwupd-signed (Ubuntu Impish):
status: New → Fix Released
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote (last edit ):

Per information from vendor, they still struggle to debug whether what they saw is a HW/FW issue. Per project status, we decide to SRU 1.5.11 back to focal.

Per check upstream git, there is no new fix in the 1.5.X breanch.

Now we have a new fwupd 1.5.11-0ubuntu2 in impish, because it enable flashrom plugin. (Ref: lp:1912371)

per check libflashrom-dev, it's versions in focal/hirsute/impish are all the same (1.2-5)

AI: decide whether we'd like to also MIR libflashrom-dev to main in focal/hirsute.

If yes, I'd need to re-work on the fwupd deb. If no, the the one in #3 shall just works.

description: updated
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Yuan-Chen, or anyone else affected,

Accepted fwupd into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.5.11-0ubuntu1~21.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in fwupd (Ubuntu Hirsute):
status: New → Fix Committed
tags: added: verification-needed verification-needed-hirsute
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Yuan-Chen, or anyone else affected,

Accepted fwupd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.5.11-0ubuntu1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in fwupd (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Yuan-Chen, or anyone else affected,

Accepted fwupd-signed into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd-signed/1.27.1ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in fwupd-signed (Ubuntu Focal):
status: New → Fix Committed
Changed in fwupd-signed (Ubuntu Hirsute):
status: New → Fix Committed
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

The hirsute upload didn't have LP bug in its changelog, but since it's given that both need to be tested/released at the same time, I accepted it as-is.

Changed in oem-priority:
status: Confirmed → In Progress
tags: added: verification-failed-focal
removed: verification-needed-focal
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote (last edit ):

found that command `fwupdmgr refresh [--force]` failed because the code in

src/fu-engine.c:3588:#if LIBJCAT_CHECK_VERSION(0, 1, 3)

if the libjcat version is less than 0.1.3, the code seems to work but will failed per test.

The output message is: "Failed to update metadata for lvfs: no signature method in results".

I attached a debdiff that force libjcat need to be >= 0.1.3. I use it in my ppa and it works fine.

Per test, the one in the hirsute does not have this bug, because libjcat is already version 0.1.3 long time ago, so it's compiled against it.

Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Yuan-Chen, or anyone else affected,

Accepted fwupd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.5.11-0ubuntu1~20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-focal
removed: verification-failed-focal
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Yuan-Chen, or anyone else affected,

Accepted fwupd-signed into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd-signed/1.27.1ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Yuan-Chen, or anyone else affected,

Accepted fwupd-signed into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd-signed/1.27.1ubuntu5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

"fwupdmgr refresh [--force]" now works on focal version 1.5.11-0ubuntu1~20.04.2.

AI: continue other verifications.

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

we found this issue along the verification process: https://github.com/fwupd/fwupd/issues/3554

Revision history for this message
Andy Chi (andch) wrote :

Prometheus finger print device cannot update on fwupd 1.3.x, which is the version on Focal, so it will not impact user to upgrade to 1.5.11. For user who installed Hirsute from the beginning. If they have never updated Prometheus and Prometheus IOTA config, they won't have impact to upgrade fwupd to 1.5.11. If the have updated Prometheus and Prometheus IOTA config, they won't have any trouble to upgrade fwupd to 1.5.11 too.

My opinion will be we can do SRU after fwupd 1.5.11 lands on -updates.

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote (last edit ):

Verification passed on Hiresute

Secure boot on
Fwupd: 1.5.11-0ubuntu1~21.04.1 (proposed)

gnome-software and snap-store firmware upgrade BIOS UI test: passed
        machine: Latitude 5300
        setup: fake newer firmware as v1.13.2
        version: 1.13.1 to 1.13.1
        Note: need to refresh snap-store snap after install from iso.

test nvme fw re-install: passed
        tested on KNBG40ZNS128G NVMe KIOXIA 128GB

test dell USB docking fw re-install: passed
        test on wd19sc, package level.

test dell TBT docking fw re-install: passed
        test on wd19tb, package level.

fwupd-tests:
        test v1.5.8 test case on fwupd 1.5.11: passed
        test v1.5.11 test case: passed

fwupdmgr update / install / reinstall sub-command: passed
        no change

dbus interface
        1.5.8 to 1.5.11: no change. passed.

tags: added: verification-done-hirsute
removed: verification-needed-hirsute
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

Verification passed on Focal

Secure boot on
shim-signed: 1.40.6+15.4-0ubuntu7 (proposed channel, sbat applied)
fwupd: 1.5.11-0ubuntu1~20.04.2 (propsoed channel, sbat applied)

gnome-software and snap-store firmware upgrade BIOS UI test: passed
        machine: Latitude 5300
        setup: fake newer firmware as v1.13.2
        version: 1.13.1 to 1.13.1

fwupd-tests:
        test v1.3.11 test case on fwupd 1.5.11, passed
        test v1.5.11 test case: passed

test nvme fw re-install
        done, tested on KXG60ZNV1T02 NVMe KIOXIA 1024GB

test dell usb docking fw re-install: passed
        done: test on wd19sc, package level.

test dell tbt docking fw re-install: passed
        done: test on wd19tb, package level.

fwupdmgr update / install / reinstall sub-command: passed
        backword compatiable per check one by one.

dbus interface: passed
        1.3.11 to 1.5.11: only add function and property.

> <method name="GetPlugins">
> <arg type="aa{sv}" name="plugins" direction="out">
> </arg>
> </method>
70a75,82
> <method name="GetHostSecurityAttrs">
> <arg type="aa{sv}" name="attrs" direction="out">
> </arg>
> </method>
> <method name="GetReportMetadata">
> <arg type="a{ss}" name="attrs" direction="out">
> </arg>
> </method>
112a125,136
> <method name="GetBlockedFirmware">
> <arg type="as" name="checksums" direction="out">
> </arg>
> </method>
> <method name="SetBlockedFirmware">
> <arg type="as" name="checksums" direction="in">
> </arg>
> </method>
> <method name="SetFeatureFlags">
> <arg type="t" name="feature_flags" direction="in">
> </arg>
> </method>
173a198,199
> </property>
> <property type="s" name="HostSecurityId" access="read">

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

for focal, it's test with libjcat 0.1.3-2~ubuntu20.04.1 from the proposed channel for sure.

Changed in oem-priority:
status: In Progress → Fix Committed
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwupd - 1.5.11-0ubuntu1~21.04.1

---------------
fwupd (1.5.11-0ubuntu1~21.04.1) hirsute; urgency=medium

  * New upstream version (1.5.11) to support Dell dock USB4 module.
    (LP: #1934209)
  * Drop all patches upstream.
  * Sync updated files from contrib/debian/ to debian/.

 -- Yuan-Chen Cheng <email address hidden> Thu, 01 Jul 2021 01:06:11 +0000

Changed in fwupd (Ubuntu Hirsute):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for fwupd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwupd-signed - 1.27.1ubuntu5

---------------
fwupd-signed (1.27.1ubuntu5) focal; urgency=medium

  * Build depend on fwupd version 1.5.11-0ubuntu1~20.04.2, take #2 (LP: #1934209)

fwupd-signed (1.27.1ubuntu4) focal; urgency=medium

  * Build depend on fwupd version 1.5.11-0ubuntu1~20.04.2 (LP: #1934209)

fwupd-signed (1.27.1ubuntu3) focal; urgency=medium

  * Build depend on fwupd version 1.5.11-0ubuntu1~20.04.1 (LP: #1934209)

 -- Julian Andres Klode <email address hidden> Mon, 26 Jul 2021 09:50:19 +0200

Changed in fwupd-signed (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.5 KiB)

This bug was fixed in the package fwupd - 1.5.11-0ubuntu1~20.04.2

---------------
fwupd (1.5.11-0ubuntu1~20.04.2) focal; urgency=medium

  * force to use libjcat >= 0.1.3, or signature verification will failed.

fwupd (1.5.11-0ubuntu1~20.04.1) focal; urgency=medium

  * New upstream version (1.5.11) to support Dell dock USB4 module.
    (LP: #1934209)
  * Drop all patches upstream.
  * Downgrade libgusb from 0.3.5 to 0.3.4 which used in focal after
    checking through all commits between.

fwupd (1.5.8-0ubuntu1) hirsute; urgency=medium

  * New upstream version (1.5.8)
  * Backport a patch to fix SBAT (LP: #1921539)
  * Drop all other patches, upstream.

fwupd (1.5.7-3) unstable; urgency=medium

  * Backport a patch to fix regression in fwupdtool activate
  * Backport a patch to fix activatable devices getting stuck in an update loop
  * Rebuild to pick up new signing keys.

fwupd (1.5.7-2) unstable; urgency=medium

  * Backport a patch to fix FTBFS on armhf for SBAT

fwupd (1.5.7-1) unstable; urgency=medium

  * New upstream version (1.5.7)
    - Fixes issues with SBAT on UEFI.
  * Fixes dependencies for -dev packages:
    Closes: #980691, #980684

fwupd (1.5.6-1) unstable; urgency=medium

  [ Steve McIntyre ]
  * Fix up Uploaders for the -signed packages - remove Jared, add Matthias

  [ Mario Limonciello ]
  * New upstream version (1.5.6)
  * drop all upstream patches

fwupd (1.5.5-2) unstable; urgency=medium

  * fwupd.postinst: Adjust to read /etc/os-release instead of `/etc/lsb-release`

fwupd (1.5.5-1) unstable; urgency=medium

  * New upstream version (1.5.5)
  * trivial: debian: migrate uefi->uefi_capsule in uefi.conf
  * trivial: debian: fix modules-load.d directory
  * trivial: debian: add dbus to recommends (Closes: #980049)
  * Backport 2 patches for continual "Unknown" message on new connections
  * trivial: debian: read /etc/lsb-release instead of dpkg-dev (Closes: #977860, #977861, #970783)

fwupd (1.5.3-2) unstable; urgency=medium

  * trivial: debian: only install fwupd-msr.conf if needed

fwupd (1.5.3-1) unstable; urgency=medium

  * New upstream version (1.5.3)
  * Drop all patches (upstream)
  * Follow defaults for nvme and redfish plugins (don't need efivar now)
  * debian/control:
    - Drop libsoup build dependency
    - Add libcurl build dependency
    - Add systemd build dependency
  * Migrate debian/fwupd.preinst content to debian/fwupd.maintscript

fwupd (1.5.1-5) unstable; urgency=medium

  * Backport patch to fix ppc64el autopkgtest failure

fwupd (1.5.1-4) unstable; urgency=medium

  * trivial: debian: disable downloading from LVFS in autopkgtest

fwupd (1.5.1-3) unstable; urgency=medium

  * Add breaks for fwupdate 12-7 (Closes: #960688)
  * trivial: debian: add git to fwupdate-tests dependencies

fwupd (1.5.1-2) unstable; urgency=medium

  [ Mario Limonciello ]
  * Backport a patch to indicate if packages are supported or not
  * backport a patch to fix autopkgtests on ppc64el
  * trivial: debian: don't hardcode paths in libexec
  * trivial: debian: disable msr plugin on all !x86

  [ Jessica Clarke ]
  * debian: Check DEB_HOST_ARCH_CPU not DEB_HOST_ARCH for MSR plugin
  * debian: Prefer Makefile substitutio...

Read more...

Changed in fwupd (Ubuntu Focal):
status: Fix Committed → Fix Released
Changed in oem-priority:
status: Fix Committed → Fix Released
status: Fix Released → In Progress
Changed in oem-priority:
status: In Progress → Fix Committed
Changed in fwupd-signed (Ubuntu Hirsute):
status: Fix Committed → Fix Released
Changed in oem-priority:
status: Fix Committed → Fix Released
Max Lee (max-lee)
information type: Public → Public Security
information type: Public Security → Public
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.