admin_state_up == false, member still ONLINE

[Michael Johnson]

In octavia, if you mark a member as admin_state_up = false, the operating_status remains ONLINE even though the member has actually be disabled.

There are two approaches available:

1. We refactor the amphora agent jinja to use the "disabled" tag on the member and for the haproxy status polling code to honor "MAINT" status.
2. We change the controller workflow to make sure the member goes into operating_status OFFLINE after the member is disabled in haproxy.

Option two has the benefit of probably helping with the pool admin_state_up = false case as well.

[Michael Johnson (johnsom)]

http://paste.openstack.org/show/srtiQPptyYj6r4SDYi9c/

So status "DRAIN" does exist, but was broken for some time. It is fixed in 1.6.10 of haproxy. We need to handle it appropriately.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/489014

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/489015

[OpenStack Infra (hudson-openstack)]

Change abandoned by Adam Harwell (<email address hidden>) on branch: master
Review: https://review.openstack.org/489014
Reason: Abandoning in favor of Honest Abe

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/489015
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=65522f5adf2171aa4d2463967d412151a62ef42f
Submitter: Jenkins
Branch: master

commit 65522f5adf2171aa4d2463967d412151a62ef42f
Author: Adam Harwell <email address hidden>
Date: Tue Aug 1 15:10:40 2017 -0700

    Correct status for disabled members (honest abe edition)

    This is *one way* to handle this problem (arguably the "correct" way).

    By actively updating the status of members that don't report, we can set
    disabled members to OFFLINE exactly when this becomes true.

    Change-Id: I908879470e5b7767711c1234063e7959aa6055ef
    Closes-Bug: #1706828

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/octavia 1.0.0.0rc1 release candidate.