get_vrrp_instance missing on NoopAmphoraLoadBalancerDriver

[Leandro Reox]

To reproduce this,

1 - leave the octavia.conf without specifing any amphora driver
2 - configure ACTIVE_BACKUP as HA strategy

Noop will be the default driver, and when trying to create a LB you will get "'NoopAmphoraLoadBalancerDriver' object has no attribute 'get_vrrp_interface'"

TRACE AS FOLLOWS:

2017-05-16 20:01:05.543 36 ERROR octavia.controller.worker.controller_worker Traceback (most recent call last):
2017-05-16 20:01:05.543 36 ERROR octavia.controller.worker.controller_worker File "/var/lib/kolla/venv/local/lib/python2
.7/site-packages/taskflow/engines/action_engine/executor.py", line 53, in _execute_task
2017-05-16 20:01:05.543 36 ERROR octavia.controller.worker.controller_worker result = task.execute(**arguments)
2017-05-16 20:01:05.543 36 ERROR octavia.controller.worker.controller_worker File "/var/lib/kolla/venv/local/lib/python2
.7/site-packages/octavia/controller/worker/tasks/amphora_driver_tasks.py", line 270, in execute
2017-05-16 20:01:05.543 36 ERROR octavia.controller.worker.controller_worker interface = self.amphora_driver.get_vrrp_
interface(amp)
2017-05-16 20:01:05.543 36 ERROR octavia.controller.worker.controller_worker AttributeError: 'NoopAmphoraLoadBalancerDrive
r' object has no attribute 'get_vrrp_interface'
2017-05-16 20:01:05.543 36 ERROR octavia.controller.worker.controller_worker

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/465185

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465185
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=dda2466edcb54486e3a0e19055aaa2bbbe162848
Submitter: Jenkins
Branch: master

commit dda2466edcb54486e3a0e19055aaa2bbbe162848
Author: Adam Harwell <email address hidden>
Date: Tue May 16 15:04:16 2017 -0700

    VRRP amphora_driver functions weren't handled by noop driver

    Also, the VRRP interface was missing one of the main methods...

    Change-Id: Ie301d3784d071b69f65aff8a306413160c079884
    Closes-Bug: #1691287

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/octavia 1.0.0.0b2 development milestone.