lb_network_name option defined on tests and CONF.getops but not used anywhere

[Leandro Reox]

The value lb_network_name from the [networking] section is defined, but its not used anywhere, this is confusing when configuring the management network for amphora

Should get removed from :

etc/octavia.conf
octavia/tests/unit/compute/drivers/test_nova_driver.py
octavia/common/config.py

And also update etc/octavia.conf naming that the lb-mgmt-net referred on the docs should be especified on the amp_boot_network_list besides any aditional network that wants to be plugged in

[Leandro Reox (leandro-reox)]

This cause the amphora boot to failure with this stacktrace

2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
s.LoadBalancerIDToErrorOnRevertTask' {'intention': 'EXECUTE', 'state': 'SUCCESS', 'requires': {'loadbalancer_id': u'6f7bfa53-13d6-4d31-9f99-f9e148b0278b'}, 'provides': None}
                                                                          |__Flow 'octavia-create-loadbalancer-flow'
2017-05-16 21:24:40.759 28 ERROR octavia.controller.worker.controller_worker Traceback (most recent call last):
2017-05-16 21:24:40.759 28 ERROR octavia.controller.worker.controller_worker File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/taskflow/engines/action_engine/executor.py", line 53, in _execute_task
2017-05-16 21:24:40.759 28 ERROR octavia.controller.worker.controller_worker result = task.execute(**arguments)
2017-05-16 21:24:40.759 28 ERROR octavia.controller.worker.controller_worker File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/octavia/controller/worker/tasks/amphora_driver_tasks.py", line 241, in execute
2017-05-16 21:24:40.759 28 ERROR octavia.controller.worker.controller_worker amphorae_network_config)
2017-05-16 21:24:40.759 28 ERROR octavia.controller.worker.controller_worker File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/octavia/controller/worker/tasks/amphora_driver_tasks.py", line 220, in execute
2017-05-16 21:24:40.759 28 ERROR octavia.controller.worker.controller_worker amphora, loadbalancer, amphorae_network_config)
2017-05-16 21:24:40.759 28 ERROR octavia.controller.worker.controller_worker File "/var/lib/kolla/venv/local/lib/python2.7/site-packages/octavia/amphorae/drivers/haproxy/rest_api_driver.py", line 112, in post_vip_plug
2017-05-16 21:24:40.759 28 ERROR octavia.controller.worker.controller_worker subnet = amphorae_network_config.get(amphora.id).vip_subnet
2017-05-16 21:24:40.759 28 ERROR octavia.controller.worker.controller_worker AttributeError: 'NoneType' object has no attribute 'get'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/465183

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465183
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=da81984492464f38857992ddecc82b4160dee1a1
Submitter: Jenkins
Branch: master

commit da81984492464f38857992ddecc82b4160dee1a1
Author: Adam Harwell <email address hidden>
Date: Tue May 16 14:49:29 2017 -0700

    Remove lb_network_name from config (it was bogus)

    This option was NEVER read, so there is no point in continuing to allow
    it to be configured (it is pointless).

    Change-Id: I147abdd8d3d95164168ec606f5b92401cb24d1fe
    Closes-Bug: #1691286

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/octavia 1.0.0.0b2 development milestone.