octavia

Auth token information missing from requests with no args

Bug #1680575 reported by Brent Eagles
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
octavia
Fix Released
Undecided
Brent Eagles

Bug Description

The fix for https://bugs.launchpad.net/neutron/+bug/1531640 nested the code for adding authentication token to the request headers in such a way that it would not get added if there were no args to the request. This caused GET and DELETE requests to fail when keystone authentication is configured, manifesting in a range of problems such as the inability to delete load balancers and for creation to never complete.

OpenStack Infra (hudson-openstack)
Changed in octavia:
assignee: nobody → Brent Eagles (beagles)
status: New → In Progress
Revision history for this message
Brent Eagles (beagles) wrote :

Proposed fix https://review.openstack.org/#/c/454172/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lbaas (master)

Reviewed: https://review.openstack.org/454172
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=9928b3a6db41608cf5a486b85f601961c7ecb3de
Submitter: Jenkins
Branch: master

commit 9928b3a6db41608cf5a486b85f601961c7ecb3de
Author: Brent Eagles <email address hidden>
Date: Thu Apr 6 10:32:46 2017 -0230

    Create header with authtoken for requests without args

    This patch adds authentication tokens to headers for requests that do
    not include arguments like DELETE and GET.

    Closes-bug: #1680575

    Change-Id: Ifc1c1e701f45eed28afc101a32e2232b3f3c3546

Changed in octavia:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lbaas (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/455765

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lbaas (stable/ocata)

Reviewed: https://review.openstack.org/455765
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=3a11200bceaac3ed521f7bfcbd3935bb1e8d0329
Submitter: Jenkins
Branch: stable/ocata

commit 3a11200bceaac3ed521f7bfcbd3935bb1e8d0329
Author: Brent Eagles <email address hidden>
Date: Thu Apr 6 10:32:46 2017 -0230

    Create header with authtoken for requests without args

    This patch adds authentication tokens to headers for requests that do
    not include arguments like DELETE and GET.

    Closes-bug: #1680575

    Change-Id: Ifc1c1e701f45eed28afc101a32e2232b3f3c3546
    (cherry picked from commit 9928b3a6db41608cf5a486b85f601961c7ecb3de)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-lbaas 11.0.0.0b1

This issue was fixed in the openstack/neutron-lbaas 11.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-lbaas 10.0.1

This issue was fixed in the openstack/neutron-lbaas 10.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.