Delete LB fails with: noauth, no project_id

[Adam Harwell]

*Reproduction*

With auth disabled:
1) Create a loadbalancer with no project_id supplied
2) Delete the loadbalancer with no project_id supplied

Expected:
LB is created and deleted

Observed:
LB is created successfully, but goes to ERROR status on delete because it is missing a project_id.

2017-01-24 10:49:35.093 19679 WARNING octavia.controller.worker.controller_worker [-] Flow 'octavia-delete-loadbalancer-flow' (9cac5fdc-97f1-40ee-bf4e-70e79d49a5f1) transitioned into state 'REVERTED' from state 'RUNNING'
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server [-] Exception during message handling
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server Traceback (most recent call last):
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 155, in _process_incoming
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 222, in dispatch
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 192, in _do_dispatch
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server result = func(ctxt, **new_args)
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/octavia/controller/queue/endpoint.py", line 55, in delete_load_balancer
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server self.worker.delete_load_balancer(load_balancer_id, cascade)
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/octavia/controller/worker/controller_worker.py", line 303, in delete_load_balancer
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server delete_lb_tf.run()
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/taskflow/engines/action_engine/engine.py", line 247, in run
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server for _state in self.run_iter(timeout=timeout):
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/taskflow/engines/action_engine/engine.py", line 340, in run_iter
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server failure.Failure.reraise_if_any(er_failures)
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/taskflow/types/failure.py", line 336, in reraise_if_any
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server failures[0].reraise()
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/taskflow/types/failure.py", line 343, in reraise
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server six.reraise(*self._exc_info)
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/taskflow/engines/action_engine/executor.py", line 53, in _execute_task
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server result = task.execute(**arguments)
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/octavia/controller/worker/tasks/database_tasks.py", line 2356, in execute
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server lock_session.rollback()
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server self.force_reraise()
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server six.reraise(self.type_, self.value, self.tb)
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/octavia/controller/worker/tasks/database_tasks.py", line 2348, in execute
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server loadbalancer.project_id)
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server File "/opt/octavia/env/lib/python2.7/site-packages/octavia/db/repositories.py", line 418, in decrement_quota
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server raise exceptions.MissingProjectID()
2017-01-24 10:49:35.093 19679 ERROR oslo_messaging.rpc.server MissingProjectID: Missing project ID in request where one is required.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/424890
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=119e223750e46faee2bddde3acd6c141fba26fca
Submitter: Jenkins
Branch: master

commit 119e223750e46faee2bddde3acd6c141fba26fca
Author: Michael Johnson <email address hidden>
Date: Tue Jan 24 14:58:29 2017 -0800

    Fix py3x gates and functional

    WIP - This patch attempts to fix the py3x gates.
    Please add to it as you find issues.

    Closes-Bug: #1659064

    Co-Authored-By: Adam Harwell <email address hidden>
    Depends-On: If6b6f19130c965436a637a03a4cf72203e0786b0

    Change-Id: If642f7ddcb886b4e9fd04a12397f26c72b3485a4

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/octavia 1.0.0.0b1 development milestone.