Reverts for DB update tasks need to be corrected

Bug #1624166 reported by Michael Johnson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
octavia
Fix Released
High
Michael Johnson

Bug Description

There are a some database update tasks that have TODO tasks to update the revert method. Currently they are just disabling the object on failure.

UpdateHealthMonInDB
UpdateMemberInDB
UpdatePoolInDB
UpdateL7PolicyInDB
UpdateL7RuleInDB

These are problematic objects as they do not have a provisioning status associated with them. Either they need a provisioning status added or parent objects need to be updated with the ERROR state and users need to be able to delete from that level down if they are in ERROR.

I think we should add provisioning status to these objects as they can be deleted via the API individually to resolve the failure.

Changed in octavia:
status: New → Triaged
Revision history for this message
Michael Johnson (johnsom) wrote :

These do have provisioning status now. The revert methods just need to be updated to reflect that change.

Changed in octavia:
assignee: nobody → Michael Johnson (johnsom)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to octavia (master)

Fix proposed to branch: master
Review: https://review.openstack.org/491558

Changed in octavia:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to octavia (master)

Reviewed: https://review.openstack.org/491558
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=579f18d627d44dca8b10bb8aeaada28a3d7758b8
Submitter: Jenkins
Branch: master

commit 579f18d627d44dca8b10bb8aeaada28a3d7758b8
Author: Michael Johnson <email address hidden>
Date: Mon Aug 7 10:52:45 2017 -0700

    Fix DB update reverts for provisioning status

    Now that all objects have a proper provisioning status, update the revert
    methods to properly set the provisioning status to error.

    Change-Id: I74e44474e7cd05979f2a9ce24143641230e4b394
    Closes-Bug: #1624166

Changed in octavia:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/octavia 1.0.0.0rc1

This issue was fixed in the openstack/octavia 1.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on octavia (master)

Change abandoned by Michael Johnson (<email address hidden>) on branch: master
Review: https://review.opendev.org/493401
Reason: There have been no updates to this patch in two years. Abandoning it.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.