DB repository calls in revert methods should have exception handling

Bug #1624047 reported by Michael Johnson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
octavia
Fix Released
Medium
Michael Johnson

Bug Description

There are a number of revert methods that make database repository calls without exception handling. This can lead to aborted revert flows. Granted, if the database is offline/unavailable we probably won't be successful with the remaining revert methods, but we should not be aborting the revert flows.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to octavia (master)

Fix proposed to branch: master
Review: https://review.openstack.org/371154

Changed in octavia:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to octavia (master)

Reviewed: https://review.openstack.org/371154
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=fb6cc70b9668ff51ec4f915aa22ab5e05bcadea2
Submitter: Jenkins
Branch: master

commit fb6cc70b9668ff51ec4f915aa22ab5e05bcadea2
Author: Michael Johnson <email address hidden>
Date: Thu Sep 15 20:54:11 2016 +0000

    Fixes the revert methods with unhandled exceptions

    A number of the revert methods in our flow tasks make database
    repository calls but do not handle potential exceptions. This can
    lead to the revert flow aborting at these tasks.

    This patch adds exception handling to these repository calls inside
    the revert methods.

    Change-Id: Ia9b07890fe2c56382041175018679b87298c1b10
    Closes-Bug: #1624047

Changed in octavia:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/octavia 0.9.0

This issue was fixed in the openstack/octavia 0.9.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.