During revert at port and/or security group may be orphaned

[Michael Johnson]

In the event of a failure in the create load balancer flow, the revert path attempts to deallocate the vip port and security groups that were created during the flow. However, this is not completing correctly and can leave an orphaned neutron port and security group. Currently the flow is logging this fact, but we should clean up this revert code to handle this situation correctly.

See the exception handling in network_task AllocateVIP revert.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/375769

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/375769
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=9d5c38afe542b0cdaa8564e7068655913bf6a8ff
Submitter: Jenkins
Branch: master

commit 9d5c38afe542b0cdaa8564e7068655913bf6a8ff
Author: Michael Johnson <email address hidden>
Date: Fri Sep 23 23:29:54 2016 +0000

    Fix orphan port/security group on revert

    In some cases the vrrp port on an amphora was not getting cleaned
    up during the revert flow. This patch makes sure we cleanup the
    vrrp ports that were created by octavia.

    Change-Id: I1b4cf53a8dbee08fe6a6a54ccc301646d89bbd85
    Closes-Bug: #1624016

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/octavia 0.9.0 release.