Installing octavia through devstack failed

[Jingjing.Li]

I want to install octavia and lbaasv2 in openstack through devstack，but an error appeared during the installing：

+++/opt/stack/octavia/devstack/plugin.sh:build_octavia_worker_image:20 git -C /opt/stack/octavia log -1 --pretty=format:%H
Unknown option: -C

then I check the ‘/opt/stack/octavia/devstack/plugin.sh’，the line20 shows：
“export DIB_REPOREF_amphora_agent=$(git -C "$OCTAVIA_DIR" log -1 --pretty="format:%H")”

the“git -C”expression should be changed to“git -c”.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/353265

[Michael Johnson (johnsom)]

This code is correct with -C. The version of git installed on your host is old or non-standard. Please see the git documentation: https://www.kernel.org/pub/software/scm/git/docs/

[li,chen (chen-li)]

@Michael Johnson (johnsom)

But the default git in CentOS are old and can not be updated by 'yum' directly, at least that happens in my set-up:

OS: centos 7
kernel: 3.10.0-327.22.2.el7.x86_64

git --version
git version 1.8.3.1

git
usage: git [--version] [--help] [-c name=value]
           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
           [-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           <command> [<args>]

May be we can use '--git-dir="$OCTAVIA_DIR"/.git' to replace '-C "$OCTAVIA_DIR"' ?

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/353265
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

[Gregory Thiemonge (gthiemonge)]

Abandoned after re-enabling the Octavia launchpad.