Octavia: Root tags should be required for request and response bodies

Bug #1544214 reported by Franklin Naval
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
octavia
Fix Released
High
Adam Harwell

Bug Description

Request and response bodies should require the root tag when doing http requests to the octavia api.
The core services such as Nova and Glance require this.
Also, it makes it easy to reuse the testing frameworks such as the clients as they enforce that rule.

see: https://specs.openstack.org/openstack/api-wg/guidelines/representation_structure.html

Tags: lbaas-merge
Changed in octavia:
importance: Undecided → High
tags: removed: lbaasv2
tags: added: lbaas-merge
Changed in octavia:
assignee: nobody → Carlos Garza (carlos-garza)
Changed in octavia:
assignee: Carlos Garza (carlos-garza) → nobody
Revision history for this message
Adam Harwell (adam-harwell) wrote :

This will be taken care of by the completed move to the v2 API (per the tag). This is almost done. I'll make sure this bug is closed in the final patch.

Changed in octavia:
assignee: nobody → Adam Harwell (adam-harwell)
Changed in octavia:
status: New → Confirmed
status: Confirmed → In Progress
Changed in octavia:
assignee: Adam Harwell (adam-harwell) → Michael Johnson (johnsom)
Changed in octavia:
assignee: Michael Johnson (johnsom) → Adam Harwell (adam-harwell)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to octavia (master)

Reviewed: https://review.openstack.org/459032
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=fb0da76c27735a965340e02cebff8be46271f579
Submitter: Jenkins
Branch: master

commit fb0da76c27735a965340e02cebff8be46271f579
Author: Adam Harwell <email address hidden>
Date: Sat Apr 22 11:12:11 2017 +0900

    Add support for single-create for APIv2

    Still need to fix the entry-points for each individual type, but that
    wasn't even in the original spec. Not sure if we even want that.

    I think this may not do things EXACTLY how the old one did it, we'll
    need to look into whether it matters, as we never published docs for it
    and I don't think it ever actually worked properly in neutron-lbaas.

    Also closing a few bugs that are only peripherally related, because we
    (possibly me) forgot to tag them on the individual CRs, but I'm
    considering them closed as of this patch. See below for my reasoning on
    each individual bug, and feel free to post counter-arguments.

    For #1673546 (single-call create): This is the obvious one!
    For #1673499 (lb return pool object): Rolled into this patch as a matter
    of course, abandoned the original fix as it is no longer relevant.
    For #1544214 (root tags): All existing resources now have root tags. Any
    new ones will also need root tags, but I would consider this bug closed.
    For #1596636 (tenant facing API): Every object is now creatable via the
    v2 API, so I would consider this to be complete. Quotas and some
    additional work is being finished, but it's not necessary for this IMO.
    For #1665446 (hm id): This was resolved in the HM patch, I just forgot
    to close it, and including it here will ensure it is release-tracked.
    For #1685789 (listener quota): Just shoving it in here as I do the
    single-create quotas.
    For #1685827 (hm quota): Same as listener quota.

    Closes-Bug: #1673546
    Closes-Bug: #1673499
    Closes-Bug: #1544214
    Closes-Bug: #1596636
    Closes-Bug: #1665446
    Closes-Bug: #1685789
    Closes-Bug: #1685827

    Depends-On: I3d86482a2999197a60a81d42afc5ef7a6e71e313

    Change-Id: I4ff03593e1cfd8dca00a13c0550d6cf95b93d746

Changed in octavia:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/octavia 1.0.0.0b2

This issue was fixed in the openstack/octavia 1.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.