Nova and Neutron client factories can return incorrect clients on second call

[Adam Harwell]

Example of the nova client cacheing and ignoring any passed args:

https://github.com/openstack/octavia/blob/240931610f9ddf97b5b141436273eda75fb4ddb2/octavia/common/clients.py#L39

If the first call to this class is a public client and the next is for an admin client, both will be public clients, causing the admin operations to fail (or the opposite).

Discussion can be found here: https://review.openstack.org/#/c/271476/8/octavia/tests/unit/common/test_clients.py

[Martin Hickey (martin-hickey)]

Hi Adam.

I can see from the description that this is a bug found during code review of the https://review.openstack.org/#/c/271476/ patch. Do you intend to work on the fix?

Thanks,
Martin

[Adam Harwell (adam-harwell)]

We're still discussing the way we want to go about fixing this -- it may or may not end up being assigned to me.

[Gregory Thiemonge (gthiemonge)]

Abandoned after re-enabling the Octavia launchpad.