If an Amphora never sends a heartbeat, it does NOT get deleted and created again

[Brandon Logan]

Currently, when an Amphora comes online it should start sending heartbeats to the health manager. The health manager also spawns a process to check if any heart beats are stale by reading the heartbeat table (amphora_health). If it detects a stale heartbeat in that table, it'll initialize a delete and recreate of the stale amphora.

If an amphora is created but never sends a heartbeat, a record is never inserted into the amphora_health table, and thus the stale heartbeat check will never know that amphora is missing heartbeats.

A solution would be to insert a row into the amphora_health table right before the load balancer is marked ACTIVE. This could have timing issues though so perhaps a better solution can be figured out.

Also, this fix is dependent on this bug getting fixed:

https://bugs.launchpad.net/octavia/+bug/1490033

AND it needs to keep in mind the solution to this bug:

https://bugs.launchpad.net/octavia/+bug/1524554

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/271512

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/271512
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Gregory Thiemonge (gthiemonge)]

Abandoned after re-enabling the Octavia launchpad.