Agent/Backend/OS/MacOS/Video.pm: use of 'strings' command

Bug #1432991 reported by geoff
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OCS Inventory: Unified Unix Agent
Fix Released
Low
Frank

Bug Description

The file '/lib/Ocsinventory/Agent/Backend/OS/MacOS/Video.pm' uses the 'strings' command to attempt to extract the display serial number from EDID data.

When this does work, it is somewhat unreliable - it is returning the model number instead of the serial number for the built-in LCD on my machine. The bigger problem is that the 'strings' command is not installed by default on os x 10.10 - as a result, the user is prompted to install the XCode tools the first time they run the OCS client.

I'm not sure what the best fix would be for this - it seems that the most reliable way to parse the EDID info would be to use something like Parse::EDID. That would introduce another dependency, but there seem to be a fair number already.

Tags: osx video
Revision history for this message
geoff (0-g-lee) wrote :

Alternatively, most of the information appears to be in the output of system_profiler SPDisplaysDataType (Not model number, but serial is there). Perhaps it would make more sense to parse this instead.

Frank (frank-bourdeau)
Changed in ocsinventory-unix-agent:
importance: Undecided → Low
Frank (frank-bourdeau)
Changed in ocsinventory-unix-agent:
status: New → Fix Released
assignee: nobody → Frank (frank-bourdeau)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.