wrong icon display in computer reports

Bug #1266229 reported by Grzegorz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OCS Inventory: OCSReports
Fix Released
Undecided
Arthur Jaouen

Bug Description

ocsreports\plugins\main_sections\ms_computer\ms_computer.php
l:130
-$nb_col=array(10,20,13);
+$nb_col=array(10,18,28,36);

and line 151 is not needed
-$j=0;

it will be nice if ms_computer page content will be ~80% or 90% width, now upper tables are about ~80% and icons are 90%

I change my self icons display to 80% then add line 149:
if ($index_tab%2 == 0) $tab_width="72%"; else $tab_width="80%";
and change line 150:
echo "</tr></table>\n<table width='$tab_width' border=0 align='center'><tr align=center>";

Grzegorz (grzesiek-4)
description: updated
Grzegorz (grzesiek-4)
description: updated
Grzegorz (grzesiek-4)
description: updated
Revision history for this message
Grzegorz (grzesiek-4) wrote :

patch for 2.1 version

Revision history for this message
Erwan (airoine) wrote :

fix commited. Committed revision 871.

Changed in ocsinventory-ocsreports:
status: New → Fix Committed
assignee: nobody → Erwan (airoine)
Revision history for this message
Grzegorz (grzesiek-4) wrote :

Hello,
Still $nb_col=array is wrong, when You got more than 20 icons, icons from 11 to 30 will be in second line, next ten 31to 40 in third line.

I got now 29 icons, and 19 icons in one line doesn't look good.
for my production (in attachment) i set $nb_col=array(10,19,29,38);
thats set in first row 10 icons, second 9, third 10 and fourth 9 if someone has more that 48 icons. then need to put more values in this array.

Grzegorz (grzesiek-4)
Changed in ocsinventory-ocsreports:
status: Fix Committed → Incomplete
Revision history for this message
Arthur Jaouen (arthur-z) wrote :

fixed with revision 879, first line have 11 icons, second line has 12 icons, and so on. This way all the base icons keep on two lines and any additional plugin will be on the next lines. the first line is 80% width, the second 90% and so on.

Changed in ocsinventory-ocsreports:
status: Incomplete → Fix Committed
assignee: Erwan (airoine) → Arthur Jaouen (arthur-z)
Arthur Jaouen (arthur-z)
Changed in ocsinventory-ocsreports:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.