| 2012-09-10 13:33:11 |
Holger Brunn (Therp) |
bug |
|
|
added bug |
| 2012-09-10 14:20:36 |
Launchpad Janitor |
branch linked |
|
lp:~therp-nl/openobject-server/6.1-lp1048643-record_is_undefined |
|
| 2012-09-10 14:26:09 |
Holger Brunn (Therp) |
branch linked |
|
lp:~therp-nl/openobject-web/6.1-lp1048643-record_is_undefined |
|
| 2012-09-10 14:30:08 |
Holger Brunn (Therp) |
branch linked |
|
lp:~therp-nl/openerp-web/6.1-lp1048643-record_is_undefined |
|
| 2012-09-10 14:38:50 |
Launchpad Janitor |
branch linked |
|
lp:~therp-nl/openerp-web/7.0-lp1048643-record_is_undefined |
|
| 2012-09-10 14:43:06 |
Holger Brunn (Therp) |
description |
If you open a dialog with a button defined on a list view, close it, do a different search and open the dialog again, it will throw the error 'record is undefined'.
To reproduce:
* Go to Settings->Modules->Modules
* Switch to list view
* Search for crm
* Click the install button for crm
* Close the dialog
* Search for account
* Click the install button for account
* Try to close the dialog
/error/
Analysis:
The dialog created in http://bazaar.launchpad.net/~openerp/openerp-web/6.1/view/head:/addons/web/static/src/js/views.js#L141 is recycled when a button is pressed multiple times, specifically on_close is not updated. But as the on_closed function that is passed uses record_id from the closure where it is created (see http://bazaar.launchpad.net/~openerp/openerp-web/6.1/view/head:/addons/web/static/src/js/view_list.js#L873), it will always search for the record_id of the first record for which the button was clicked.
This then goes wrong if the current search result doesn't contain this record.
Trunk has the same problem, even though http://bazaar.launchpad.net/~openerp/openerp-web/trunk/revision/2863.1.6 fixes the closure, you still end up calling reload_record with the wrong id.
Patch follows in a while. |
If you open a dialog with a button defined on a list view, close it, do a different search and open the dialog again, it will throw the error 'record is undefined' when trying to close this one.
To reproduce:
* Go to Settings->Modules->Modules
* Switch to list view
* Search for crm
* Click the install button for crm
* Close the dialog
* Search for account
* Click the install button for account
* Try to close the dialog
/error/
Analysis:
The dialog created in http://bazaar.launchpad.net/~openerp/openerp-web/6.1/view/head:/addons/web/static/src/js/views.js#L141 is recycled when a button is pressed multiple times, specifically on_close is not updated. But as the on_closed function that is passed uses record_id from the closure where it is created (see http://bazaar.launchpad.net/~openerp/openerp-web/6.1/view/head:/addons/web/static/src/js/view_list.js#L873), it will always search for the record_id of the first record for which the button was clicked.
This then goes wrong if the current search result doesn't contain this record.
Trunk has the same problem, even though http://bazaar.launchpad.net/~openerp/openerp-web/trunk/revision/2863.1.6 fixes the closure, you still end up calling reload_record with the wrong id.
Patch follows in a while. |
|
| 2012-09-18 09:40:13 |
Amit Bhavsar (Open ERP) |
openerp-web: status |
New |
Confirmed |
|
| 2012-09-18 09:40:19 |
Amit Bhavsar (Open ERP) |
openerp-web: importance |
Undecided |
Low |
|
| 2012-09-18 09:40:36 |
Amit Bhavsar (Open ERP) |
openerp-web: assignee |
|
OpenERP Publisher's Warranty Team (openerp-opw) |
|
| 2012-10-29 13:13:11 |
Nicolas Vanhoren (OpenERP) |
nominated for series |
|
openerp-web/6.1 |
|
| 2012-10-29 13:13:11 |
Nicolas Vanhoren (OpenERP) |
bug task added |
|
openerp-web/6.1 |
|
| 2012-10-29 13:13:11 |
Nicolas Vanhoren (OpenERP) |
nominated for series |
|
openerp-web/trunk |
|
| 2012-10-29 13:13:11 |
Nicolas Vanhoren (OpenERP) |
bug task added |
|
openerp-web/trunk |
|
| 2012-10-29 13:13:17 |
Nicolas Vanhoren (OpenERP) |
openerp-web/6.1: status |
New |
Confirmed |
|
| 2012-10-29 13:13:19 |
Nicolas Vanhoren (OpenERP) |
openerp-web/6.1: importance |
Undecided |
Low |
|
| 2012-10-29 13:13:27 |
Nicolas Vanhoren (OpenERP) |
openerp-web/6.1: assignee |
|
OpenERP Publisher's Warranty Team (openerp-opw) |
|
| 2012-10-29 13:13:34 |
Nicolas Vanhoren (OpenERP) |
openerp-web/trunk: status |
Confirmed |
Invalid |
|
| 2012-10-29 13:13:37 |
Nicolas Vanhoren (OpenERP) |
openerp-web/trunk: assignee |
OpenERP Publisher's Warranty Team (openerp-opw) |
|
|
| 2013-01-24 16:29:10 |
Holger Brunn (Therp) |
bug task added |
|
therp-backports |
|
| 2013-01-24 16:29:22 |
Holger Brunn (Therp) |
nominated for series |
|
therp-backports/web-6.1 |
|
| 2013-01-24 16:29:22 |
Holger Brunn (Therp) |
bug task added |
|
therp-backports/web-6.1 |
|
| 2013-01-24 16:29:36 |
Holger Brunn (Therp) |
therp-backports/web-6.1: status |
New |
Confirmed |
|
| 2013-01-24 16:30:22 |
Holger Brunn (Therp) |
therp-backports/web-6.1: importance |
Undecided |
High |
|
| 2013-03-31 11:31:59 |
Stefan Rijnhart (Opener) |
therp-backports/web-6.1: status |
Confirmed |
Fix Committed |
|
| 2013-03-31 11:32:02 |
Stefan Rijnhart (Opener) |
therp-backports: status |
New |
Fix Committed |
|
| 2014-01-29 09:21:12 |
Yann Papouin |
bug task added |
|
ocb-web |
|
| 2014-01-29 09:21:34 |
Yann Papouin |
nominated for series |
|
ocb-web/6.1 |
|
| 2014-01-29 09:21:34 |
Yann Papouin |
bug task added |
|
ocb-web/6.1 |
|
