[6.1][7.0][trunk] Search for product and product category is not made for a daily use

[Yann Papouin]

The name_search method does not take into account common case in daily use (see examples below), the user should not have to remove the brackets to have a match:

Consider a product A:
- default_code = 'REFA'
- name = 'My product A'

Consider a product B:
- default_code = 'REFB'
- name = 'My product B

The current name_get returns:
- [REFA] My product A

If the user edit the name_get the following cases are not allowing to retrieve any of the products above:
- [REFA
- [REF

Another model case: product.category, the user should be able to retrieve a category even when the category separator is used. Consider the following categories:

- All products / Main Group / Group A
- All products / Main Group / Group B
- All products / Main Group / Group C
- All products / Another Group / Group A
- All products / Another Group / Group B

If the user edit the name_get the following cases are not allowing to retrieve any of the categories above:

- All products / Main Group / Group A
- All products / Main Group / Grou
- All products / Main Group /
- All products / Main

[Yann Papouin (yann-papouin)]

See my proposal attached

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Yann, I think you are mixing two concepts: name_get and name_search. Both methods are used with differente purposes: on one hand, name_get retrieves the visible name that the record is going to have got, and on the other, name_search allow to make any query with parameters supplied, and usually returning the output as a list on "name_get records".

On product, name_search allows to search by reference or by name, so you can search entering 'REF' the products REFA and REFB, but '[REF' is not working, because there isn't any reference that contains the bracket.

On category, name_search only searches for the name of the leaf category, which I consider also that is not convenient, but any other thing is a change of behaviour, not a bug. I have made a module that changes this behaviour, which I'm going to attach to this bug.

Regards.

[Pedro Manuel Baeza (pedro.baeza)]

This module is for v7, but easily backportable to v6.1

[Yann Papouin (yann-papouin)]

Thanks Pedro for your module, but that's not the behaviour I was looking for.

Personally, I think that anything done into name_get must be undone in name_search since their behaviours are inter-connected:
- If the product name_get adds brackets in name_get they must be removed before search in name_search
- If the category name_get adds slashes in name_get they must be removed before search in name_search

Please note that OpenERP SA already did this for product but only when both brackets are there, I'm just extending their process by removing extra brackets. And since nothing exists for product category, I implemented the same process there.

Note that this change should allow to fix one of my old bug report:
https://bugs.launchpad.net/openobject-server/+bug/812340