[7.0] Can't reset a refused vacation request if its amount of days exceeds available days
Bug #1303724 reported by
Holger Brunn (Therp)
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Odoo Addons (MOVED TO GITHUB) |
New
|
Undecided
|
Unassigned | |||
| OpenERP Community Backports (Addons) | Status tracked in 7.0 | |||||
| 7.0 |
New
|
Undecided
|
Unassigned | |||
Bug Description
To reproduce:
- create 10 days of leave for your employee
- make a vacation request (called A) for your employee for 10 days
- refuse vacation vacation request A
- make another vacation request for your employee for 5 days
- try to reset vacation request A to draft
This fails because the workflow transition to act_confirm is called automatically and there's not enough vacation left. Note that you also can't delete this request as unlink only allows that in the draft, cancel and confirm states.
In trunk, this problem is solved by having the user click a button to confirm a vacation request.
Related branches
lp:~therp-nl/ocb-addons/7.0-lp1303724
- Pedro Manuel Baeza: Approve (code review)
- Omar (Pexego): Approve (code review)
-
Diff: 11 lines (+1/-0)1 file modifiedhr_holidays/hr_holidays.py (+1/-0)
To post a comment you must log in.
