Activity log for bug #1254631

Date Who What changed Old value New value Message
2013-11-25 09:17:00 Stefan Rijnhart (Opener) bug added bug
2013-11-25 09:22:57 Stefan Rijnhart (Opener) description Steps to reproduce: ================ 1 Create a partner with a bank account. Create a contact on that partner. Note that you cannot add a bank account to the contact directly, because the bank accounts are supposed to be configured on the commercial/parent partner. 2 Create an invoice for the contact Expected results: ============== When selecting the contact, I expect the parent partner's bank account to be filled in on the invoice's 'Other Info' tab. Actual results: ============ The bank account is not added to the invoice. Moreover, when trying to select the bank account manually, the domain on partner_id prevents this. No bank account can be selected even if the contact's commercial partner has a bank account configured. Analysis and proposed solution: ========================= When invoicing a contact, the onchange method considers the bank accounts of the contact, not of the commercial partner. This should be easy to fix in 7.0 in the onchange method The bank domain cannot be properly fixed under the stable policy as it depends on having the commercial_partner_id field available in the invoice form. In trunk, applying this field in the domain should fix the problem. Steps to reproduce: ================ 1 Create a partner with a bank account. Create a contact on that partner. Note that you cannot add a bank account to the contact directly, because the bank accounts are supposed to be configured on the commercial/parent partner. 2 Create an invoice for the contact Expected results: ============== When selecting the contact, I expect the parent partner's bank account to be filled in on the invoice's 'Other Info' tab. Actual results: ============ The bank account is not added to the invoice. Moreover, when trying to select the bank account manually, the domain on partner_id prevents this. No bank account can be selected even if the contact's commercial partner has a bank account configured. Analysis and proposed solution: ========================= When invoicing a contact, the onchange method considers the bank accounts of the contact, not of the commercial partner. This should be easy to fix in 7.0 in the onchange method. However, this is seems meaningless to me if no choice can be made in the case of multiple accounts anyway, due to the problem with the domain. The bank domain cannot be properly fixed under the stable policy as it depends on having the commercial_partner_id field available in the invoice form. In trunk, applying this field in the domain should fix the problem.
2013-11-25 09:35:40 Launchpad Janitor branch linked lp:~therp-nl/banking-addons/7.0-lp1254631-contact_bank_account_on_invoice
2013-11-26 06:46:47 Twinkle Christian(OpenERP) openobject-addons: importance Undecided Medium
2013-11-26 06:46:47 Twinkle Christian(OpenERP) openobject-addons: status New Confirmed
2013-11-26 06:46:47 Twinkle Christian(OpenERP) openobject-addons: assignee OpenERP R&D Addons Team 3 (openerp-dev-addons3)
2013-11-26 06:48:19 Twinkle Christian(OpenERP) summary [7.0] No bank account on invoice when invoicing a contact No bank account on invoice when invoicing a contact
2013-12-30 08:46:53 Twinkle Christian(OpenERP) tags invoicing
2014-04-22 13:31:04 Pedro Manuel Baeza branch linked lp:~pedro.baeza/openobject-addons/fix-lp_1254631
2014-04-22 13:38:18 Pedro Manuel Baeza branch linked lp:~pedro.baeza/ocb-addons/fix-lp_1254631
2014-04-22 13:40:45 Pedro Manuel Baeza bug task added ocb-addons
2014-04-22 13:40:57 Pedro Manuel Baeza nominated for series ocb-addons/7.0
2014-04-22 13:40:57 Pedro Manuel Baeza bug task added ocb-addons/7.0
2014-04-22 13:41:07 Pedro Manuel Baeza ocb-addons/7.0: status New Fix Committed
2014-04-22 13:41:14 Pedro Manuel Baeza openobject-addons: status Confirmed Fix Committed