bug l10n_be_coda: creation of bank account because the matching is wrong

[Houssine]

Hi,

Here we have a little bug concerning creation of unnecessary bank account on partner the following code at line 44

http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/view/head:/l10n_be_coda/l10n_be_coda.py#L44

make a wrong matching cause it doens't take into account the difference between to format of bank account number. In fact, the account number from the coda come totally stripped from space charachter while the one of the patner is iban format for example BEXX XXXX XXXX XXXX.

Applying the given patch should solve this problem.

[Houssine (houssine-bakkali)]

replace the line 44 by this code. Sorry I'm getting the branch and it taking too long so this is all I can provide for now.

cr.execute("select id from res_partner_bank where replace(replace(acc_number,' ',''),'-','') = %s",(str(data['coda_account_number']),))
            ids = [id[0] for id in cr.fetchall()]
            # Filter bank accounts which are not allowed
            acc_number_ids = self.pool.get('res.partner.bank').search(cr, uid, [('id', 'in', ids)])

[Rifakat Husen (OpenERP) (rha-openerp)]

Hi Houssine,

You are perfectly right. I just fixed is in below branch on rev 9351,
lp:~openerp-dev/openobject-addons/7.0-opw-596039-rha
Revision ID: <email address hidden>

I appreciate your work,
Rifakat

[Houssine (houssine-bakkali)]

great job Rifakat! Thanks again!

[Houssine (houssine-bakkali)]

Hi Guys,

could we have some progress getting this merged please? Anything blocking somewhere?

We need this to be merged for releasing at customer site!

Thanks
Houssine