Fails to compile with GCC 4.6 (unless using -fpermissive)

[Adam Williamson]

Trying to build nux 0.9.36 with GCC 4.6 (Fedora 15) I hit multiple errors in RenderingPipeGLSL.cpp:

[adamw@adam SPECS]$ grep error: /var/lib/mock/fedora-15-x86_64/result/build.log
./RenderingPipeGLSL.cpp:906:131: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:967:131: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1043:131: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1126:131: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1203:131: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1279:131: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1368:131: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1447:130: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1500:131: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1565:131: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1640:130: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1701:130: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1770:130: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1841:130: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1910:130: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:1981:130: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:2059:130: error: taking address of temporary [-fpermissive]
./RenderingPipeGLSL.cpp:2520:131: error: taking address of temporary [-fpermissive]

from Google, looks like GCC 4.6 is clamping down on some coding error or other here. I don't know what, I'm not a coder. :)

[Adam Williamson (awilliamson)]

Fedora's handy-dandy guide to GCC 4.6 changes - http://lists.fedoraproject.org/pipermail/devel/2011-February/148523.html - says:

http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164704
http://gcc.gnu.org/ml/gcc-patches/2010-09/msg02144.html

This used to be just a warning, now it is an error (unless -fpermissive). Please don't add -fpermissive, instead just add a variable and pass address of the variable if at all possible.

[Hicham HAOUARI (funnylife-ma)]

Attached patch fixes it

[Hicham HAOUARI (funnylife-ma)]

Also don't redefine GLEW_MX since it is define in glewmx pkgconfig file

[Hicham HAOUARI (funnylife-ma)]

the glew_mx patch breaks unity build, as a side note, so GLEW_MX needs to be defined in unity

[Didier Roche-Tolomelli (didrocks)]

Setting as high now that oneiric have 4.6 by default. Thanks Adam, I'm currently trying to build nux with your patch to unbreak nux in oneiric.

Upstream should do a proper review and integrate it for next oneiric upload.

[Launchpad Janitor (janitor)]

This bug was fixed in the package nux - 0.9.48-0ubuntu2

---------------
nux (0.9.48-0ubuntu2) oneiric; urgency=low

  * debian/patches/01_build_with_gcc46.patch:
    - Fix Fails to compile with GCC 4.6 (thanks Adam Williamson) (LP: #745392)
  * debian/control, rules, patches/series:
    - add quilt infrastructure
 -- Didier Roche <email address hidden> Wed, 18 May 2011 13:13:49 +0200

[Adam Williamson (awilliamson)]

just for the record, you should probably thank Hicham, not me: he wrote the patch :)

[Marco Biscaro (marcobiscaro2112)]

Updating status.