nux autolanding builds encounter make check-headless failures on i386 builds

[Francis Ginther]

Some make check-headless tests fail only on i386 builds.

[Test Case]
make check-headless fails:
[ FAILED ] 4 tests, listed below:
[ FAILED ] TestAnimateValue.TestAdvance
[ FAILED ] TestAnimateValue.TestAnimatePoint
[ FAILED ] TestAnimationHookup.TestTwoAnimation
[ FAILED ] TestAnimationHookup.TestIntProperty

Build log is available here:
http://jenkins.qa.ubuntu.com/job/nux-mbs-autolanding-inline-convert/./build=pbuilder,distribution=quantal,flavor=i386/2/console

Failures were found during autolanding build for conversion to inline packaging in MP:
https://code.launchpad.net/~mterry/nux/inline-debian/+merge/132978

Temporarily working around failures in order to land inline packaging change. However, next attempt to land an MP against lp:nux will fail w/o a fix for this.

[Stephen M. Webb (bregma)]

Marking as critical because failing test cases either fail to validate anything or indicate critical problems. Either way, this blocks proper validation of the software and must be fixed as soon as possible.

[Eleni Maria Stea (hikiko)]

I ve commented out the assert parts of the tests that fail so that we can move on, but I didn't fix anything on the broken tests.

[Jay Taoko (jaytaoko)]

I cannot reproduce this bug on a local machine with nux trunk. Can anyone reproduce?

[Michael Terry (mterry)]

Specifically, this looks like a floating point -> int problem. Not with the tests, but in NuxCore/Animation-inl.h's AnimateValue::Advance.

It's tricky because AnimateValue is templated, so we can't just insert some rounding logic.

[Tim Penhey (thumper)]

This is a long long issue differeing on 64bit vs 32bit installs.

I have reproduced on my 32 bit server.

[Stephen M. Webb (bregma)]

I can repro this consistently in my 32-bit environments (i386, armhf).

I also have a fairly reasonable fix in the pipe.