Service request: Soundcloud

[Jiří Janoušek]

Original reporter: https://launchpad.net/~p-meyhoefer

Integrate Soundcloud (http://soundcloud.com/ )

[mikeycgto (mikeycgto)]

I'd like to give this a whirl.

[Jiří Janoušek (fenryxo)]

mikeycgto, sorry for late reply, are you still interested in this task?

[Sebastian Schlatow (buzz-dee)]

Yes

[Jiří Janoušek (fenryxo)]

On Mon, Aug 12, 2013 at 9:03 PM, Sebastian Schlatow
<email address hidden> wrote:
> Yes

That was question for mikeycgto whether he still wants to take care of
integration of Soundcloud.

[k-rock (i-pfennigstorf)]

Well, I just did some basic implementation, but fear it does violate soundcloud's terms, so guess i'll keep it private. What do you think?

https://soundcloud.com/terms-of-use#your-use-of-the-platform

[k-rock (i-pfennigstorf)]

Just wrote an email to soundcloud asking for legal advice

[Jiří Janoušek (fenryxo)]

> Just wrote an email to soundcloud asking for legal advice

I think it's the best solution. Thanks for contacting them.

[Jiří Janoušek (fenryxo)]

Since development of Nuvola Player has been discontinued [1], I'm closing the bug tracker. It will be reopened when a new maintainer is found. I'm sorry I wasn't able to address this issue.

[1] https://launchpad.net/nuvola-player/+announcement/11960

[Jiří Janoušek (fenryxo)]

k-rock (i-pfennigstorf)
> Just wrote an email to soundcloud asking for legal advice

What did the legals replyed?

[k-rock (i-pfennigstorf)]

Didn't get an answer yet - but I'm using the service on a daily basis. What do you suggest?

[Jiří Janoušek (fenryxo)]

> Didn't get an answer yet - but I'm using the service on a daily basis.
> What do you suggest?

I think it's very unlikely they would sue us because of one little
unimportant application that improves user experience of their webapp.
Would you like to share your sevice integration then?

[k-rock (i-pfennigstorf)]

https://github.com/ipf/nuvola-soundcloud here you go

[Jiří Janoušek (fenryxo)]

Thanks, code review follows.

description.html:

You have forgotten to replace dummy text from template with real text

metadata.conf:

> maintainer_link = https://github.com/ipf/nuvola-soundcloud/

If you would like to ship service integration with Nuvola Player releases, you must use URL of your Launchpad profile.

integration.js

- Add yourself to the list of copyright holders at the top of the file.

- Values of variables can_prev, can_next, state, can_thumbs_up must be set according to real state of
  the web app. For example, state must be Nuvola.STATE_NONE on start-up, Nuvola.STATE_PAUSED
  when song is paused and Nuvola.STATE_PLAYING when music is really playing.

- Is in neccessary to hide hide welcome message or is it only a benefit?

+ if (this.can_thumbs_up !== can_thumbs_up)
+ {
+ this.can_thumbs_up = can_thumbs_up;
+ Nuvola.updateAction(Nuvola.ACTION_THUMBS_UP, can_thumbs_up);
+ }

If thumbs up action in never available you should set it to false only once in Integration constructor.

+ case Nuvola.ACTION_PAUSE:
+ $('.playControl').click();
+ break;

You should add a condition if (this.state == Nuvola.STATE_PLAYING)

+ case Nuvola.ACTION_THUMBS_DOWN:
+ alert("Thumbs down!");
+ break;

Don't use alert().

[Brett Mayson (bmandesigns)]

I have created a SoundCloud service I have been using personally for a few days now.

https://github.com/BmanDesignsCanada/nuvola-soundcloud

[Jiří Janoušek (fenryxo)]

Thanks Brett. If you would like to maintain your service integration script as a part of the Nuvola Player project, please port it to Nuvola Player3: http://tiliado.github.io/nuvolaplayer/development/apps/porting.html

[Brett Mayson (bmandesigns)]

I should be able to do that over this weekend.

[Jiří Janoušek (fenryxo)]

This bug has been moved to the new bug tracker at GitHub.
https://github.com/tiliado/nuvolaplayer/issues/30