Service request: Jango

[Jiří Janoušek]

The fix is available as a service update package. See https://nuvolaplayer.fenryxo.cz/download/service_updates.html (Jango, version 1.0).

Fix committed to lp:nuvola-player as r838. Will be released in Nuvola Player 2.5.0. <http://bazaar.launchpad.net/~fenryxo/nuvola-player/trunk/revision/838>

Original reporter: https://launchpad.net/~pabloalmeidaff9
Homepage: http://www.jango.com/

[Jiří Janoušek (fenryxo)]

Since development of Nuvola Player has been discontinued [1], I'm closing the bug tracker. It will be reopened when a new maintainer is found. I'm sorry I wasn't able to address this issue.

[1] https://launchpad.net/nuvola-player/+announcement/11960

[Stefano Bagnatica (thepisu)]

I created a service integration for Jango: http://www.jango.com/

It supports everything (I think) possible:
- set current song title and artist
- set current station name as album name
- set current song image as album art image
- player status
- play / pause commands
- go to next song (previous not applicable to Jango)
- thumb up (= set as favourite) and thumb down (= ban); as Jango request a confirm with a button click after thumb up / down, I managed to click this confirm automatically, to avoid having click into the page

I can mantain this service integration for future changes / improvements.

[Jiří Janoušek (fenryxo)]

Thanks for your work. Please don't use make_service_package.sh, just tar+gzip the main jango directory. Code review follows :-)

description.html

- Wrap content to maximal width of 100 chars per line.
- The text "jango.com is totally legal..." could be removed.
- Known issues section is marked as work in progress. Finish it or remove it.

integration.js

Add yourself to the list of copyright holders at the top of the file.

> if (ctrlstatus == "player_ctrls pause") {
> return true;
> } else {
> return false;
> }

Use `return ctrlstatus == "player_ctrls pause";`.

> Integration.prototype.messageHandler = function(cmd)
> {
> // for thumbs up / down
> var autoCommit = function(trycount) {

There is no need to define autoCommit function everytime messageHandler is called. Define it only once as Integration.prototype.autoCommit and call it as this.autoCommit().

[Stefano Bagnatica (thepisu)]

Attached new package (only jango directory) with requested fixes.

I also moved my other functions to Integration.prototype.*.

[Stefano Bagnatica (thepisu)]

I found an issue when using my Jango service integration, but I don't know what cause it, and how to fix.

When calling NEXT SONG feature (skip button on Jango) appears a message box saying that Nuvola Player need a plugin for "ABOUT protocol source".

It seems that somewhat in the page try calling an about:blank page, that is not managed by Nuvola Player.

Please not that that message appears not only using the NEXT SONG command in Nuvola Player, but also clicking the SKIP BUTTON directly on Jango page (from inside Nuvola Player web browser).

Can you take a look, to see if it's something to manage in service integration, or in core code? Maybe you have to "catch" the about:blank request and block it?

[Jiří Janoušek (fenryxo)]

> When calling NEXT SONG feature (skip button on Jango) appears a message box saying that Nuvola Player need a plugin for "ABOUT protocol source".

See bug #1320663 https://bugs.launchpad.net/nuvola-player/+bug/1320663

[Jiří Janoušek (fenryxo)]

Looks fine. One last question: Is the icon created from scratch or derived from Jango logo?

[Stefano Bagnatica (thepisu)]

The icon was created from Jango logo (taking only the "j"). If this is a problem, we can remove the custom icon, like other recently created service integrations. I'm not very good in icon creation...

[Stefano Bagnatica (thepisu)]

I have found a bug in the integration: the thumb up / thumb down don't work, because of the way I called autoCommit function (without passing reference to integration object).

So I'm attaching fixed package.

[Jiří Janoušek (fenryxo)]

Hi Stefano, I've removed the icon because of copyright. The last tarball seems to have same content as the previous one. Are you sure it's the right one?

[Stefano Bagnatica (thepisu)]

Sorry, you're right. Here the updated package.