ToString not working properly for some properties

[Dale King]

The following code:

            Console.WriteLine(Has.Property("foo").EqualTo("bar"));
            Console.WriteLine(Has.Property("foo").EqualTo("bar").And.Property("baz").EqualTo("qux"));
            Console.WriteLine(Has.Property("foo").EqualTo("bar") & Has.Property("baz").EqualTo("qux"));

prints the following

<equal "bar">
<equal "qux">
<and <property foo <equal "bar">> <property baz <equal "qux">>>

Only the last one is correct.

[Dale King (dalewking)]

Looking through the code it appears the problem here is that Constraint.ToString does not check to see if the constaint has a builder. I believe that if builder is not null then it needs to call ToString on the builder.

[Charlie Poole (charlie.poole)]

Ah. That makes it less serious than I feared. In our tests, ToString is normally only called on a constraint that has been resolved... I'll see if your suggestion works. If not, I'll put some indication in the output that it's an unresolved constraint. We definitely don't want ToString() to resolve the constraint as a side effect.

[Charlie Poole (charlie.poole)]

After giving it some thought, I fixed this by having ToString() produce output that clearly indicates the constraint is unresolved. So, for example, Console.WriteLine( Is.Not.All.EqualTo(5).ToString() ) produces <unresolved <equal 5>>

While not giving all the info, this clearly warns the person using ToString() that something is amiss.

The repeatability issue, which is related to this problem, will be fixed separately.