NUnit uses wrong priority-scheme for addins

Bug #600554 reported by W van Gool
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
NUnit V2
Fix Released
High
Charlie Poole

Bug Description

Version: 2.5.5, GUI Runner.

When a custom SuiteBuilder on the SuiteBuilder-extension point is installed, and this SuiteBuilder is designed to build TestSuites from Types that (re)use the standard NUnit-attributes (TestFixtureAttribute, TestAttribute, etc), the built-in NUnitTestFixtureBuilder attempts to build TestFixtures from these types, instead of letting the custom SuiteBuilder take care of them. This effectively disabled the installed SuiteBuilder, unless you force not to (re)use any of the standard NUnit-attributes in your custom TestFixture-classes, which is not desirable.

The solution: NUnit should feed Types to any custom SuiteBuilder before falling back to the built-in builder (as was the case in previous versions).

NB: this may also be true for all other extension points (i.e. custom TestCaseBuilders).

Related branches

Revision history for this message
Charlie Poole (charlie.poole) wrote : Re: [Bug 600554] [NEW] NUnit uses wrong priority-scheme for addins

Regarding other extension points: This does apply to the TestCaseBuilder
extension point. TestDecorator implements it's own priority scheme and
order is not relevant to other extension points. Since only the two builders
really care about the installation order, we should be able to make the
change globally without harmful effect.

Charlie

On Thu, Jul 1, 2010 at 2:49 AM, W van Gool <email address hidden> wrote:
> Public bug reported:
>
> Version: 2.5.5, GUI Runner.
>
> When a custom SuiteBuilder on the SuiteBuilder-extension point is
> installed, and this SuiteBuilder is designed to build TestSuites from
> Types that (re)use the standard NUnit-attributes (TestFixtureAttribute,
> TestAttribute, etc), the built-in NUnitTestFixtureBuilder attempts to
> build TestFixtures from these types, instead of letting the custom
> SuiteBuilder take care of them. This effectively disabled the installed
> SuiteBuilder, unless you force not to (re)use any of the standard NUnit-
> attributes in your custom TestFixture-classes, which is not desirable.
>
> The solution: NUnit should feed Types to any custom SuiteBuilder before
> falling back to the built-in builder (as was the case in previous
> versions).
>
> NB: this may also be true for all other extension points (i.e. custom
> TestCaseBuilders).
>
> ** Affects: nunitv2
>     Importance: Undecided
>         Status: New
>
> --
> NUnit uses wrong priority-scheme for addins
> https://bugs.launchpad.net/bugs/600554
> You received this bug notification because you are a member of NUnit
> Developers, which is subscribed to NUnit V2.
>

Changed in nunitv2:
status: New → Triaged
importance: Undecided → High
Changed in nunitv2:
assignee: nobody → Charlie Poole (charlie.poole)
Changed in nunitv2:
milestone: none → 2.5.6
Changed in nunitv2:
status: Triaged → Invalid
status: Invalid → Fix Committed
Changed in nunitv2:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers