categorie contains dash or trail spaces is not selectable

Bug #590717 reported by Dmitry Malkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
NUnit Framework
High
Charlie Poole
NUnit V2
Fix Released
Medium
Charlie Poole

Bug Description

PS C:\umpc> NUnit\nunit-console-x86.exe /labels bin/Debug/LauncherTest.dll /exclude="A-"
NUnit version 2.5.5.10112
Copyright (C) 2002-2009 Charlie Poole.
Copyright (C) 2002-2004 James W. Newkirk, Michael C. Two, Alexei A. Vorontsov.
Copyright (C) 2000-2002 Philip Craig.
All Rights Reserved.

Runtime Environment -
   OS Version: Microsoft Windows NT 6.1.7600.0
  CLR Version: 4.0.30319.1 ( Net 4.0 )

ProcessModel: Default DomainUsage: Single
Execution Runtime: net-4.0
Excluded categories: A-
***** LauncherTest.Bug.A

Tests run: 1, Errors: 0, Failures: 0, Inconclusive: 0, Time: 0,0470027 seconds
  Not run: 0, Invalid: 0, Ignored: 0, Skipped: 0

//////////////////////////////////////////////////////////////////////////

[Category("A-")]
[Test]
public void A()
{
}

Related branches

Revision history for this message
Dmitry Malkin (myh016) wrote :

affect only console version

Changed in nunitv2:
status: New → Triaged
importance: Undecided → Medium
milestone: none → 2.5.6
Revision history for this message
Charlie Poole (charlie.poole) wrote :

We should reject names with - or + in them to avoid confusion.

Changed in nunitv2:
assignee: nobody → Charlie Poole (charlie.poole)
Revision history for this message
Charlie Poole (charlie.poole) wrote :

Fixed in 2.5.6 by disallowing the offending characters. A test with such a category name is considered not runnable. Trailing spaces are now trimmed.

For 3.0, it's not clear yet how we will deal with this. We may have an entirely different selection syntax.

Changed in nunitv2:
status: Triaged → Fix Committed
Changed in nunitv2:
status: Fix Committed → Fix Released
tags: added: v2port
Changed in nunit-3.0:
status: New → Triaged
importance: Undecided → High
Changed in nunit-3.0:
assignee: nobody → Charlie Poole (charlie.poole)
milestone: none → 2.9.5
status: Triaged → Fix Committed
Changed in nunit-3.0:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers