Need of Enddate together with Ignore

[Rechenelf]

[Issue now tracked at https://github.com/nunit/nunit-framework/issues/45]

In our framework we have a feature that is very important for us: Ignore can has two parameters description and enddate. When enddate is less then the current date, the test is not longer be igrnored and (normally) displayed as a test with error.

Currently, there is more than one part to change, because Ignore ist also used with TestCase, TestFisture and so on.
Ignore, IgnoreReason, IgnoreUpto, IgnoreReasonUppto will then be needed.

[Charlie Poole (charlie.poole)]

Please explain the need for two different IgnoreReason fields - I understand
the rest.

Charlie

On Thu, Sep 2, 2010 at 7:57 AM, Rechenelf <email address hidden> wrote:
> Public bug reported:
>
> In our framework we have a feature that is very important for us: Ignore
> can has two parameters description and enddate. When enddate is less
> then the current date, the test is not longer be igrnored and (normally)
> displayed as a test with error.
>
> Currently, there is more than one part to change, because Ignore ist also used with TestCase, TestFisture and so on.
> Ignore, IgnoreReason, IgnoreUpto, IgnoreReasonUppto will then be needed.
>
> ** Affects: nunitv2
>     Importance: Undecided
>         Status: New
>
>
> ** Tags: attribute enddate feature ignore
>
> --
> Need of Enddate together with Ignore
> https://bugs.launchpad.net/bugs/628881
> You received this bug notification because you are a member of NUnit
> Developers, which is subscribed to NUnit V2.
>

[Rechenelf (matklaus)]

Ignore == Ignore ;-)
IgnoreReason == Ignore(reason) e.x Ignore("Still under construction")
IgnoreReasonUpto == Ignore(reason, a date) e.x Ignore("Only for the big endtest", 1.1.2011)
IgnoreUpto == Ignore(a date) e.x Ignore(1.1.2011)

Ignore with Parameter as Attribute, IgnoreReason and so on as Parameter of some Attributes, which must be ignorable (TestCase, ...)

[Charlie Poole (charlie.poole)]

The point of my question was why not just...

TestCase(..., IgnoreReason="xxxxxx", UpTo="1.1.2011"

Having a separate IgnoreReasonUpTo parameter allows setting two reasons, one
of which will be ignored under the current implementation.

Charlie

On Fri, Sep 3, 2010 at 2:44 AM, Rechenelf <email address hidden> wrote:
> Ignore == Ignore  ;-)
> IgnoreReason == Ignore(reason)   e.x Ignore("Still under construction")
> IgnoreReasonUpto  == Ignore(reason, a date)     e.x Ignore("Only for the big endtest", 1.1.2011)
> IgnoreUpto  == Ignore(a date)     e.x Ignore(1.1.2011)
>
> Ignore with Parameter as Attribute, IgnoreReason and so on as Parameter
> of some Attributes, which must be ignorable (TestCase, ...)
>
> --
> Need of Enddate together with Ignore
> https://bugs.launchpad.net/bugs/628881
> You received this bug notification because you are a member of NUnit
> Developers, which is subscribed to NUnit V2.
>

[Rechenelf (matklaus)]

All right, if you split it in two parameters it would also be possible only to use UpTo and then the meaning is not clear. I think better would be:
TestCase(..., IgnoreReason="xxxxxx", IgnoreUpTo="1.1.2011"
The test is ignored, if Ignore, IgnoreReason or IgnoreUpTo is present and reason is not empty or date is expired.

[Charlie Poole (charlie.poole)]

Probably the Ignore property will be eliminated, and a reason will be required.

On Tue, Sep 7, 2010 at 3:29 PM, Rechenelf <email address hidden> wrote:
> All right, if you split it in two parameters it would also be possible only to use UpTo and then the meaning is not clear. I think better would be:
> TestCase(..., IgnoreReason="xxxxxx", IgnoreUpTo="1.1.2011"
> The test is ignored, if Ignore, IgnoreReason or IgnoreUpTo is present and reason is not empty or date is expired.
>
> --
> Need of Enddate together with Ignore
> https://bugs.launchpad.net/bugs/628881
> You received this bug notification because you are a member of NUnit
> Developers, which is subscribed to NUnit V2.
>

[Charlie Poole (charlie.poole)]

Postponed to 3.0