New Real Time Battle

Todo: Review the NRTB C++ common classes

Bug #723272 reported by Rick Stovall
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
New Real Time Battle
Fix Released
Medium
George Jordan

Bug Description

Please get the code branch lp:~fpstovall/nrtb/cpp_common from https://code.launchpad.net/~fpstovall/nrtb/cpp_common and review the C++ utility classes in the common directory.

Related branches

lp:~fpstovall/nrtb/cpp_common
DougPiranha (community): Approve (process control)
George Jordan: Approve (functional review for merge)
Rick Stovall: Approve (merge test)
Aron Boyette: Pending requested
jdrakey: Pending requested
Diff: 9400 lines (+6194/-2510)
62 files modified
GPB_proto/ack_nak.proto (+3/-0)
GPB_proto/physics_common.proto (+2/-0)
GPB_proto/sim_obj_tq_update.proto (+2/-0)
GPB_proto/sim_to_db_wrapper.proto (+2/-0)
common/GPB/Makefile (+34/-0)
common/Makefile (+31/-4)
common/common_rl/Makefile (+36/-0)
common/common_rl/common.cpp (+274/-0)
common/common_rl/common.h (+171/-0)
common/common_rl/common_rl_test.cpp (+101/-0)
common/confreader/Makefile (+38/-0)
common/confreader/confreader.cpp (+226/-0)
common/confreader/confreader.h (+287/-0)
common/confreader/conftest.cpp (+129/-0)
common/confreader/test.config (+27/-0)
common/logger/Makefile (+42/-0)
common/logger/log_setup.cpp (+43/-0)
common/logger/log_setup.h (+30/-0)
common/logger/log_test.cpp (+46/-0)
common/plugin_loader/Makefile (+0/-29)
common/plugin_loader/doc/plugins.xmi (+0/-339)
common/plugin_loader/plugin_manager.cpp (+0/-127)
common/plugin_loader/plugin_manager.h (+0/-194)
common/plugin_loader/plugin_wrapper.cpp (+0/-146)
common/plugin_loader/plugin_wrapper.h (+0/-207)
common/plugin_loader/test/Makefile (+0/-13)
common/plugin_loader/test/plugintest.cpp (+0/-12)
common/point/Makefile (+30/-13)
common/point/common_test.cpp (+99/-44)
common/point/triad.h (+54/-27)
common/serializer/Makefile (+36/-0)
common/serializer/serializer.cpp (+43/-0)
common/serializer/serializer.h (+50/-0)
common/serializer/serializer_test.cpp (+56/-0)
common/singleton/Makefile (+0/-18)
common/singleton/singleton.h (+0/-110)
common/singleton/singleton_test.cpp (+0/-32)
common/sockets/Makefile (+38/-0)
common/sockets/base_socket.cpp (+853/-0)
common/sockets/base_socket.h (+588/-0)
common/sockets/socket_test.cpp (+200/-0)
common/threads/Makefile (+36/-0)
common/threads/base_thread.cpp (+497/-0)
common/threads/base_thread.h (+627/-0)
common/threads/tests/cond_var.h (+124/-0)
common/threads/tests/general.h (+194/-0)
common/threads/tests/loop_counter.h (+76/-0)
common/threads/thread_test.cpp (+77/-0)
common/timer/Makefile (+36/-147)
common/timer/hires_timer.cpp (+174/-0)
common/timer/hires_timer.h (+131/-0)
common/timer/nrtb_timer.cpp (+0/-158)
common/timer/nrtb_timer.h (+0/-115)
common/timer/timer_test.cpp (+59/-27)
common/transceiver/Makefile (+31/-0)
common/transceiver/transceiver.cpp (+140/-0)
common/transceiver/transceiver.h (+276/-0)
common/transceiver/transceiver_test.cpp (+145/-0)
common/work_queue_thread/Makefile (+0/-144)
common/work_queue_thread/controlled_wqt.h (+0/-202)
common/work_queue_thread/work_queue_thread.h (+0/-248)
common/work_queue_thread/wqt_tester.cpp (+0/-154)
Revision history for this message
Rick Stovall (fpstovall) wrote :

Please create bugs for any issues you may find and assign them to me (fpstovall). Thanks!!

Note: Transceiver is not complete at this time... no need to reviiew it yet unless you are bored.

Revision history for this message
Rick Stovall (fpstovall) wrote :

Code is not quite complete yet, currently working on unit tests for the common_rl lib. After that I will complete transceiver.

Changed in nrtb:
status: New → In Progress
status: In Progress → New
Revision history for this message
George Jordan (gsjordanc) wrote :

Starting review of code.....

Rick Stovall (fpstovall)
Changed in nrtb:
assignee: jdrakey (jadrakey) → George Jordan (gsjordanc)
Rick Stovall (fpstovall)
Changed in nrtb:
status: New → In Progress
Revision history for this message
George Jordan (gsjordanc) wrote :

Threads looks good. Passes compile and makefile unit tests.

Code review good. No obvious problems.

Revision history for this message
Rick Stovall (fpstovall) wrote :

I believe the alpha expectations for the C++ common classes have been met as of this date. Any issues you find from a pull from cpp_common after this point on should be treated as defects to be opened and assigned to fpstovall. Enjoy!

Rick Stovall (fpstovall)
Changed in nrtb:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.