Todo: Several dbAccess:: methods improperly return a error flag

[Rick Stovall]

Method int dbAccess::runSql (string scrpt) returns an int indicating success or failure and carrying no other significance. Best practices indicate that the method should succeed cleanly or throw an exception, therefore the return of a status flag is redundant; a failure would never return the error code in any case.

Given the above, the method should be altered to not return any type of status code and to throw an exception (may I suggest dbAccess::runSql_failure as a name) should the query fail. A nice enhancement would be to store the error code and text in the exception so the actual event and problem can be resolved by the caller if needed.

One other question while we are here, was the mis-spelling of "script" in the argument list intentional?

[Rick Stovall (fpstovall)]

I altered this bug to generally include all the dbAccess:: methods which return a status int. Please make the changes noted above in each of those cases, using distinct and meaningful exception names, of course.

[Rick Stovall (fpstovall)]

Altered status to reflect this is still open to debate.

[Rick Stovall (fpstovall)]

Abandoned.. overrun by the port to D