lacp_bonds needs to check aggrID from links that are up (or false positives will happen)

[Alvaro Uria]

We need to exclude aggregator ID check on links that are DOWN.

$ egrep . /sys/class/net/bond0/{operstate,bonding/ad_aggregator}
/sys/class/net/bond0/operstate:up
/sys/class/net/bond0/bonding/ad_aggregator:2

$ egrep . /sys/class/net/enp[45]s0f0/{operstate,bonding_slave/ad_aggregator_id}
/sys/class/net/enp4s0f0/operstate:up
/sys/class/net/enp5s0f0/operstate:down
/sys/class/net/enp4s0f0/bonding_slave/ad_aggregator_id:2
/sys/class/net/enp5s0f0/bonding_slave/ad_aggregator_id:6

# sudo -u nagios /usr/local/lib/nagios/plugins/check_lacp_bond.py -i bond0
CRITICAL: aggregator_id mismatch (bond0:2 - enp5s0f0:6)

There is another config parameter (netlinks) that can check the operstate of an interface.

[Aurelien Lourot (aurelien-lourot)]

Note: meanwhile CRITICAL has been changed to WARNING in the product but the bug is still valid.