Remaining ports are not unbound if one port is missing

[Stephen Finucane]

As part of the instance deletion process, we must unbind ports associated with said instance. To do this, we loop over all ports currently attached to an instance. However, if neutron returns HTTP 404 (Not Found) for any of these ports, we will return early and fail to unbind the remaining ports. We've seen the problem in the context of Kubernetes on OpenStack. Our deinstaller is brute-force, so it deletes ports and servers at the same time, so a race means the port can get deleted early. This normally wouldn't be an issue as we'd just "untrunk" it and proceed to delete it. But that won't work for SR-IOV ports as in that case you cannot "untrunk" bound ports.

The solution here is obvious: if we fail to find a port, we should simply skip that and continue unbinding everything else.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/842528
Committed: https://opendev.org/openstack/nova/commit/9e0dcb52ab308a63c6a18e47d1850cc3ade4d807
Submitter: "Zuul (22348)"
Branch: master

commit 9e0dcb52ab308a63c6a18e47d1850cc3ade4d807
Author: Stephen Finucane <email address hidden>
Date: Thu May 19 12:04:08 2022 +0100

    neutron: Unbind remaining ports after PortNotFound

    Just because we encountered a PortNotFound error when unbinding a port
    doesn't mean we should stop unbinding the remaining ports. If this error
    is encountered, simply continue with the other ports.

    While we're here, we clean up some other tests related to '_unbind_port'
    since they're clearly duplicates.

    Change-Id: Id04e0df12829df4d8929e03a8b76b5cbe0549059
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-Bug: #1974173

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/nova/+/842584

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/nova/+/842586

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/nova/+/842587

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/842588

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/nova/+/842590

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/nova/+/842592

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/842584
Committed: https://opendev.org/openstack/nova/commit/6f32b118640ee466b58155b5ecd50e041b4a2e7e
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 6f32b118640ee466b58155b5ecd50e041b4a2e7e
Author: Stephen Finucane <email address hidden>
Date: Thu May 19 12:04:08 2022 +0100

    neutron: Unbind remaining ports after PortNotFound

    Just because we encountered a PortNotFound error when unbinding a port
    doesn't mean we should stop unbinding the remaining ports. If this error
    is encountered, simply continue with the other ports.

    While we're here, we clean up some other tests related to '_unbind_port'
    since they're clearly duplicates.

    Change-Id: Id04e0df12829df4d8929e03a8b76b5cbe0549059
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-Bug: #1974173
    (cherry picked from commit 9e0dcb52ab308a63c6a18e47d1850cc3ade4d807)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 26.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/842586
Committed: https://opendev.org/openstack/nova/commit/d322f8e8b5a95fd60dab9c6c543b4c77ea893836
Submitter: "Zuul (22348)"
Branch: stable/xena

commit d322f8e8b5a95fd60dab9c6c543b4c77ea893836
Author: Stephen Finucane <email address hidden>
Date: Thu May 19 12:04:08 2022 +0100

    neutron: Unbind remaining ports after PortNotFound

    Just because we encountered a PortNotFound error when unbinding a port
    doesn't mean we should stop unbinding the remaining ports. If this error
    is encountered, simply continue with the other ports.

    While we're here, we clean up some other tests related to '_unbind_port'
    since they're clearly duplicates.

    Conflicts:
      nova/tests/unit/network/test_neutron.py

    NOTE(stephenfin): Conflicts are due to the absence of change
    I8058902df167239fa455396d3595a56bcf472b2b ("neutron: Rework how we check
    for extensions") which we don't want to backport.

    Change-Id: Id04e0df12829df4d8929e03a8b76b5cbe0549059
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-Bug: #1974173
    (cherry picked from commit 9e0dcb52ab308a63c6a18e47d1850cc3ade4d807)
    (cherry picked from commit 6f32b118640ee466b58155b5ecd50e041b4a2e7e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 24.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 25.1.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/nova/+/842592
Reason: stable/train branch of nova projects' have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/nova/+/842590
Reason: stable/ussuri branch of openstack/nova transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/842588
Reason: stable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/nova/+/842587
Reason: stable/wallaby branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/wallaby if you want to further work on this patch.