vpmem - libvirt.libvirtError: XML error: Invalid value for element or attribute 'maxMemory'

Bug #1845905 reported by Rui Zang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Eric Fried
Train
Fix Committed
High
Dan Smith

Bug Description

The result of Python3 divide operation is float point. This resulted in an invalid value for 'maxMemory' entry of libvirt domain xml which expects an integer.

Rui Zang (rui-zang)
Changed in nova:
status: New → In Progress
assignee: nobody → Rui Zang (rui-zang)
Changed in nova:
assignee: Rui Zang (rui-zang) → Eric Fried (efried)
Dan Smith (danms)
tags: added: train-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/685742

Revision history for this message
Eric Fried (efried) wrote :

Fix previously proposed to branch: master (bot didn't pick it up here)
Review: https://review.opendev.org/685593

Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/685593
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6d5fdb4ef4dc3e5f40298e751d966ca54b2ae902
Submitter: Zuul
Branch: master

commit 6d5fdb4ef4dc3e5f40298e751d966ca54b2ae902
Author: LuyaoZhong <email address hidden>
Date: Sun Sep 29 08:54:41 2019 +0000

    make virtual pmem feature compatible with python3

    convert floating-point number to integer when generating
    vpmem xml.

    Co-Authored-By: Eric Fried <email address hidden>
    Change-Id: I6e94150820bf31a8404ef257db2b64b0d2ee9763
    Closes-Bug: 1845905

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/train)

Reviewed: https://review.opendev.org/685742
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e5f1cd3c1e4ff0b46932bd1ad858974d4c930881
Submitter: Zuul
Branch: stable/train

commit e5f1cd3c1e4ff0b46932bd1ad858974d4c930881
Author: LuyaoZhong <email address hidden>
Date: Sun Sep 29 08:54:41 2019 +0000

    make virtual pmem feature compatible with python3

    convert floating-point number to integer when generating
    vpmem xml.

    Co-Authored-By: Eric Fried <email address hidden>
    Change-Id: I6e94150820bf31a8404ef257db2b64b0d2ee9763
    Closes-Bug: 1845905
    (cherry picked from commit 6d5fdb4ef4dc3e5f40298e751d966ca54b2ae902)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 20.0.0.0rc2

This issue was fixed in the openstack/nova 20.0.0.0rc2 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.