Comment 12 for bug 1845243

Reviewed: https://review.opendev.org/686063
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ff29f7018fdd4fc12b6b029ebef25904f9455aa9
Submitter: Zuul
Branch: stable/stein

commit ff29f7018fdd4fc12b6b029ebef25904f9455aa9
Author: melanie witt <email address hidden>
Date: Fri Sep 27 02:10:22 2019 +0000

    Reduce scope of 'path' query parameter to noVNC consoles

    This is a partial revert of commit
    9606c80402f6db20d62b689c58aa8f024183628a which added the 'path' query
    parameter to work with noVNC v1.1.0. This broke all other console types
    using websockify server (serial, spice) because the websockify server
    itself doesn't know how to handle the 'path' query parameter. It is the
    noVNC vnc_lite.html file which parses the 'path' variable and uses it
    as the url to the websockify server. So, all other console types should
    *not* be generating a console access url with a 'path' query parameter,
    only noVNC.

    Closes-Bug: #1845243

    TODO(melwitt): Figure out how to test serial and/or spice console in
    the gate

    NOTE(melwitt): The difference in nova/tests/unit/console/test_websocketproxy.py
    from the Train change is because change
    I0498599fd636aa9e30df932f0d893db5efa23260 is not in Stein.

    Change-Id: I9521f21a685edc44121d75bdf534c201fa87c2d7
    (cherry picked from commit 54125a75fb056dbea115408610f90e7d6eee5139)
    (cherry picked from commit e736babdfea277720634ac00fd9dc119042837b9)