Annoying log on nova-compute startup with default configuration: "WARNING [nova.compute.monitors] Excluding nova.compute.monitors.cpu monitor virt_driver. Not in the list of enabled monitors (CONF.compute_monitors)."

[Matt Riedemann]

The CPU monitor stuff in nova-compute is essentially frozen / deprecated and not enabled by default, but the compute service logs a warning on every startup that it's not being used - which if you've configured the service to not use it, great - who cares - we don't need a warning:

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Excluding%20nova.compute.monitors.cpu%20monitor%20virt_driver.%20Not%20in%20the%20list%20of%20enabled%20monitors%20(CONF.compute_monitors).%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22&from=7d

https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.compute_monitors

The help in that config option is also misleading since it mentions "numa_mem_bw" which does not exist in nova.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/650092

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/650092
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8795f591d541227cd704019f19f3a78c74fc8ac7
Submitter: Zuul
Branch: master

commit 8795f591d541227cd704019f19f3a78c74fc8ac7
Author: Matt Riedemann <email address hidden>
Date: Thu Apr 4 14:13:16 2019 -0400

    Do not log a warning about not using compute monitors

    The compute_monitors configuration option is empty by
    default, however, on nova-compute startup we get a warning
    logged saying:

      Excluding nova.compute.monitors.cpu monitor virt_driver. \
      Not in the list of enabled monitors (CONF.compute_monitors).

    This is unnecessary noise in the logs when nova-compute is
    not configured to use monitors, so this change avoids the warning
    log message in that case.

    The compute_monitors configuration option help text is also
    updated to (1) fix formatting and (2) remove the mention of the
    numa_mem_bw monitor which never made it into nova (see
    blueprint memory-bw).

    Change-Id: I5bd204e0017f6f795e3cf13b34b75124ee23aa78
    Closes-Bug: #1823207

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.openstack.org/650929

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/650929
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fe5c8a517a74e344903131c283d676c5e06bb5e6
Submitter: Zuul
Branch: stable/stein

commit fe5c8a517a74e344903131c283d676c5e06bb5e6
Author: Matt Riedemann <email address hidden>
Date: Thu Apr 4 14:13:16 2019 -0400

    Do not log a warning about not using compute monitors

    The compute_monitors configuration option is empty by
    default, however, on nova-compute startup we get a warning
    logged saying:

      Excluding nova.compute.monitors.cpu monitor virt_driver. \
      Not in the list of enabled monitors (CONF.compute_monitors).

    This is unnecessary noise in the logs when nova-compute is
    not configured to use monitors, so this change avoids the warning
    log message in that case.

    The compute_monitors configuration option help text is also
    updated to (1) fix formatting and (2) remove the mention of the
    numa_mem_bw monitor which never made it into nova (see
    blueprint memory-bw).

    Change-Id: I5bd204e0017f6f795e3cf13b34b75124ee23aa78
    Closes-Bug: #1823207
    (cherry picked from commit 8795f591d541227cd704019f19f3a78c74fc8ac7)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 19.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.