"Overwriting current allocation" warnings in logs during move operations although there are no failures

[Matt Riedemann]

I'm not sure why this is a warning:

https://github.com/openstack/nova/blob/b33fa1c054ba4b7d4e789aa51250ad5c8325da2d/nova/scheduler/client/report.py#L1880

Because it shows up in normal operations during a resize where allocations are moved from the instance to the migration record as of this blueprint in queens:

https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/migration-allocations.html

This ends up being a lot of log spam:

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Overwriting%20current%20allocation%5C%22%20AND%20tags%3A%5C%22screen%5C%22&from=7d

The warning was added in this change:

https://github.com/openstack/nova/commit/53ca096750685b7bb88c2a5062db19d92facc548

But I'm not sure why. It should probably be INFO or DEBUG.

[Takashi Natsume (natsume-takashi)]

The "Overwriting current allocation" log message is output when reverting resize.
So it is a normal case.

[Matt Riedemann (mriedem)]

Yeah I discussed this with gibi in IRC today and he didn't have any reason for the warning except it seemed like overwriting allocations was a bad idea, but maybe didn't connect that to the fact we are intentionally doing it when reverting the resize, so the warning should probably just be dropped to DEBUG level.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/649788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/649788
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d955ce42cc16149cc9ffe7f698210d85792b63a0
Submitter: Zuul
Branch: master

commit d955ce42cc16149cc9ffe7f698210d85792b63a0
Author: Takashi NATSUME <email address hidden>
Date: Thu Apr 4 11:17:06 2019 +0900

    Change a log level for overwriting allocation

    Change a log level for overwriting allocation
    to debug instead of warning
    because the log message is output in the normal case
    of reverting resize.

    Change-Id: I4f2ee3f420b4c78385eeb56c7e8c343af894e75c
    Closes-Bug: #1822917

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.openstack.org/652994

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/652994
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2bbd7f4a0ce0df0a5d1789848796178491fbea40
Submitter: Zuul
Branch: stable/stein

commit 2bbd7f4a0ce0df0a5d1789848796178491fbea40
Author: Takashi NATSUME <email address hidden>
Date: Thu Apr 4 11:17:06 2019 +0900

    Change a log level for overwriting allocation

    Change a log level for overwriting allocation
    to debug instead of warning
    because the log message is output in the normal case
    of reverting resize.

    Change-Id: I4f2ee3f420b4c78385eeb56c7e8c343af894e75c
    Closes-Bug: #1822917
    (cherry picked from commit d955ce42cc16149cc9ffe7f698210d85792b63a0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 19.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.