Quobyte mount validation needs update

Bug #1730933 reported by Silvan Kaiser on 2017-11-08
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Undecided
Silvan Kaiser
OpenStack Compute (nova)
Undecided
Silvan Kaiser
Stein
Undecided
Silvan Kaiser

Bug Description

The Quobyte driver currently validates mounts, amongst other checks, by verifying the mounts device field has a 'quobyte@' prefix [1]. Setting this will be replaced in the Quobyte client by setting a fuse subtype. The driver should be able to cope with both variants in order to stay compatible to all Quobyte releases.

[1] https://github.com/openstack/cinder/blob/fb27334719fb612d2d5386b7d9de374d4a415d81/cinder/volume/drivers/quobyte.py#L476

Silvan Kaiser (2-silvan) on 2017-11-08
Changed in cinder:
assignee: nobody → Silvan Kaiser (2-silvan)

Fix proposed to branch: master
Review: https://review.openstack.org/518515

Changed in cinder:
status: New → In Progress

Reviewed: https://review.openstack.org/518515
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=ac0583c94acb8f960e9b6e242ce3e6eb604962c0
Submitter: Zuul
Branch: master

commit ac0583c94acb8f960e9b6e242ce3e6eb604962c0
Author: Silvan Kaiser <email address hidden>
Date: Wed Nov 8 12:56:29 2017 +0100

    Added mount fstype based validation of Quobyte mounts

    The validation of Quobyte mounts is extended to validate based
    on a mounts file system type being set to "fuse.quobyte".

    Closes-Bug: #1730933

    Change-Id: I50430d67c2b9952d0b0c200920491c31f88a7ad7

Changed in cinder:
status: In Progress → Fix Released
Silvan Kaiser (2-silvan) wrote :

Added the Nova project as this issue hits the Quobyte Nova drivers mount point validation, too.

Changed in nova:
assignee: nobody → Silvan Kaiser (2-silvan)

Fix proposed to branch: master
Review: https://review.openstack.org/522245

Changed in nova:
status: New → In Progress

This issue was fixed in the openstack/cinder 12.0.0.0b2 development milestone.

Reviewed: https://review.openstack.org/609698
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=a1d67d52f79656ce9c7f4b326d2703d972c35d9a
Submitter: Zuul
Branch: stable/pike

commit a1d67d52f79656ce9c7f4b326d2703d972c35d9a
Author: Silvan Kaiser <email address hidden>
Date: Wed Nov 8 12:56:29 2017 +0100

    Added mount fstype based validation of Quobyte mounts

    The validation of Quobyte mounts is extended to validate based
    on a mounts file system type being set to "fuse.quobyte".

    Closes-Bug: #1730933

    Change-Id: I50430d67c2b9952d0b0c200920491c31f88a7ad7
    (cherry picked from commit ac0583c94acb8f960e9b6e242ce3e6eb604962c0)

tags: added: in-stable-pike

This issue was fixed in the openstack/cinder 11.2.0 release.

Reviewed: https://review.openstack.org/522245
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=05a73c0f3a9f8edf9024f9870279bc6fb7bba2e7
Submitter: Zuul
Branch: master

commit 05a73c0f3a9f8edf9024f9870279bc6fb7bba2e7
Author: Silvan Kaiser <email address hidden>
Date: Wed Nov 22 14:35:11 2017 +0100

    Added mount fstype based validation of Quobyte mounts

    The validation of Quobyte mounts is extended to validate based
    on a mounts file system type being set to "fuse.quobyte".
    This includes adding a new StaleVolumeMount exception type to
    the Nova exceptions.
    This also closes a bug concerning multi-registry configurations
    for Quobyte volumes due to no longer using the is_mounted()
    method that failed in that case.
    Finally this adds exception handling for the unmount call that
    is issued on trying to mount an already mounted volume.

    Closes-Bug: #1730933
    Closes-Bug: #1737131

    Change-Id: Ia5a23ce1123a68608ee2ec6f2ac5dca02da67c59

Changed in nova:
status: In Progress → Fix Released

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers