commit c6a42cd3b38528bbf410b33c3bfc384600ae053f
Author: Matt Riedemann <email address hidden>
Date: Mon Mar 25 13:16:42 2019 -0400
Error out migration when confirm_resize fails
If anything fails and raises an exception during
confirm_resize, the migration status is stuck in
"confirming" status even though the instance status
may be "ERROR".
This change adds the errors_out_migration decorator
to the confirm_resize method to make sure the migration
status is "error" if an error is raised.
In bug 1821594 it was the driver.confirm_migration
method that raised some exception, so a unit test is
added here which simulates a similar scenario.
This only partially closes the bug because we are still
leaking allocations on the source node resource provider
since _delete_allocation_after_move is not called. That
will be dealt with in a separate patch.
Reviewed: https:/ /review. opendev. org/652150 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=c6a42cd3b38 528bbf410b33c3b fc384600ae053f
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit c6a42cd3b38528b bf410b33c3bfc38 4600ae053f
Author: Matt Riedemann <email address hidden>
Date: Mon Mar 25 13:16:42 2019 -0400
Error out migration when confirm_resize fails
If anything fails and raises an exception during
confirm_resize, the migration status is stuck in
"confirming" status even though the instance status
may be "ERROR".
This change adds the errors_ out_migration decorator
to the confirm_resize method to make sure the migration
status is "error" if an error is raised.
In bug 1821594 it was the driver. confirm_ migration
method that raised some exception, so a unit test is
added here which simulates a similar scenario.
This only partially closes the bug because we are still allocation_ after_move is not called. That
leaking allocations on the source node resource provider
since _delete_
will be dealt with in a separate patch.
Conflicts:
nova/ tests/unit/ compute/ test_compute_ mgr.py
NOTE(mriedem): The conflict is due to not having change 47efb806cf88204 10c8bc80eccca25 in Queens.
Ia05525058e
Change-Id: Ic7d78ad43a2bad 7f932c22c98944a ccbbed9e9e2 64aa5d769d6d01f d9340de2e5) fe8d3020ff95db0 e6a840a224) aa60e9a267f2505 0729f7766c)
Partial-Bug: #1821594
(cherry picked from commit 408ef8f84a698f7
(cherry picked from commit 972d4e0eb391e83
(cherry picked from commit e3f69c8af0d13f0