hypervisor check in _check_instance_has_no_numa() is broken

Bug #1818092 reported by Chris Friesen on 2019-02-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
High
Chris Friesen
Rocky
High
Stephen Finucane

Bug Description

In commit ae2e5650d "Fail to live migration if instance has a NUMA topology" there is a check against hypervisor_type.

Unfortunately it tests against the value "obj_fields.HVType.KVM". Even when KVM is supported by qemu the libvirt driver will still report the hypervisor type as "QEMU". So we need to fix up the hypervisor type check otherwise we'll always fail the check.

Changed in nova:
assignee: nobody → Chris Friesen (cbf123)
status: New → In Progress
Matt Riedemann (mriedem) on 2019-02-28
tags: added: stein-rc-potential
Changed in nova:
importance: Undecided → High
Matt Riedemann (mriedem) wrote :

Yeah this is a long-standing source of confusion, see bug 1195361.

Reviewed: https://review.openstack.org/635350
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4da058723332a58323640fabce3d95902946a07d
Submitter: Zuul
Branch: master

commit 4da058723332a58323640fabce3d95902946a07d
Author: Chris Friesen <email address hidden>
Date: Wed Feb 6 14:57:12 2019 -0600

    fix up numa-topology live migration hypervisor check

    It turns out that even when KVM is supported by qemu the libvirt
    driver will report the hypervisor type as "QEMU". So we need to
    fix up the hypervisor type check in the live migration code that
    checks whether the instance has a NUMA topology.

    Closes-Bug: #1818092
    Change-Id: I5127227a1e3d76dd413a820b048547ba578aff6b
    Signed-off-by: Chris Friesen <email address hidden>

Changed in nova:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/640462
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ecdf3c67ee464139d8a6f9cb8d332857f261228b
Submitter: Zuul
Branch: stable/rocky

commit ecdf3c67ee464139d8a6f9cb8d332857f261228b
Author: Chris Friesen <email address hidden>
Date: Wed Feb 6 14:57:12 2019 -0600

    fix up numa-topology live migration hypervisor check

    It turns out that even when KVM is supported by qemu the libvirt
    driver will report the hypervisor type as "QEMU". So we need to
    fix up the hypervisor type check in the live migration code that
    checks whether the instance has a NUMA topology.

    Closes-Bug: #1818092
    Change-Id: I5127227a1e3d76dd413a820b048547ba578aff6b
    Signed-off-by: Chris Friesen <email address hidden>
    (cherry picked from commit 4da058723332a58323640fabce3d95902946a07d)

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

This issue was fixed in the openstack/nova 18.2.0 release.

Reviewed: https://review.opendev.org/648939
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9cbd2aeddec61c58aad5fd3efcf16c65612d2db7
Submitter: Zuul
Branch: stable/queens

commit 9cbd2aeddec61c58aad5fd3efcf16c65612d2db7
Author: Chris Friesen <email address hidden>
Date: Wed Feb 6 14:57:12 2019 -0600

    fix up numa-topology live migration hypervisor check

    It turns out that even when KVM is supported by qemu the libvirt
    driver will report the hypervisor type as "QEMU". So we need to
    fix up the hypervisor type check in the live migration code that
    checks whether the instance has a NUMA topology.

    Closes-Bug: #1818092
    Change-Id: I5127227a1e3d76dd413a820b048547ba578aff6b
    Signed-off-by: Chris Friesen <email address hidden>
    (cherry picked from commit 4da058723332a58323640fabce3d95902946a07d)
    (cherry picked from commit ecdf3c67ee464139d8a6f9cb8d332857f261228b)

tags: added: in-stable-queens

This issue was fixed in the openstack/nova 17.0.11 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers