Unnecessary warning when ironic node properties are not set

Bug #1794773 reported by Mark Goddard on 2018-09-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
Mark Goddard
Queens
Low
Mark Goddard
Rocky
Low
Mark Goddard

Bug Description

If an ironic node is registered without either of the 'memory_mb' or 'cpus' properties, the following warning messages are seen in the nova-compute logs:

Warning, memory usage is 0 for <instance> on baremetal node <node>.
Warning, number of cpus is 0 for <instance> on baremetal node <node>.

As of the Rocky release [1], the standard compute resources (VCPU, MEMORY_MB, DISK_GB) are not registered with placement for ironic nodes. They were not required to be set since the Pike release, but still this warning is emitted.

[1] https://review.openstack.org/#/c/565841/

Changed in nova:
assignee: nobody → Mark Goddard (mgoddard)
status: New → In Progress

Reviewed: https://review.openstack.org/605754
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=63b9c88386998bc584786ecb8ea7a2aae971a384
Submitter: Zuul
Branch: master

commit 63b9c88386998bc584786ecb8ea7a2aae971a384
Author: Mark Goddard <email address hidden>
Date: Thu Sep 27 15:32:36 2018 +0100

    Don't emit warning when ironic properties are zero

    If an ironic node is registered without either of the 'memory_mb' or
    'cpus' properties, the following warning messages are seen in the
    nova-compute logs:

    Warning, memory usage is 0 for <instance> on baremetal node <node>.
    Warning, number of cpus is 0 for <instance> on baremetal node <node>.

    As of the Rocky release [1], the standard compute resources (VCPU,
    MEMORY_MB, DISK_GB) are not registered with placement for ironic nodes.
    They were not required to be set since the Pike release, but still this
    warning is emitted.

    This change removes these warning messages.

    Backport: rocky, queens, pike

    [1] https://review.openstack.org/#/c/565841/

    Change-Id: I342b9b12ec869431c3abad75eb8194c34151a281
    Closes-Bug: #1794773

Changed in nova:
status: In Progress → Fix Released
Matt Riedemann (mriedem) wrote :

The comment in the bug report description linking to [1] https://review.openstack.org/#/c/565841/ was merged in Stein, not Rocky.

Reviewed: https://review.openstack.org/608573
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0794345ecd1d61efb7a0d321eb32844d2dd684d0
Submitter: Zuul
Branch: stable/rocky

commit 0794345ecd1d61efb7a0d321eb32844d2dd684d0
Author: Mark Goddard <email address hidden>
Date: Thu Sep 27 15:32:36 2018 +0100

    Don't emit warning when ironic properties are zero

    If an ironic node is registered without either of the 'memory_mb' or
    'cpus' properties, the following warning messages are seen in the
    nova-compute logs:

    Warning, memory usage is 0 for <instance> on baremetal node <node>.
    Warning, number of cpus is 0 for <instance> on baremetal node <node>.

    As of the Stein release [1], the standard compute resources (VCPU,
    MEMORY_MB, DISK_GB) are not registered with placement for ironic nodes.
    They were not required to be set since the Pike release, but still this
    warning is emitted.

    This change removes these warning messages.

    Backport: rocky, queens, pike

    [1] https://review.openstack.org/#/c/565841/

    NOTE(mriedem): The original commit message on this change incorrectly
    said that [1] was made in Rocky but it was actually made in Stein.
    The important part is that the "memory_mb" and "cpus" properties on
    the node could be 0 since Pike and if they are 0, it just means
    that the related standard resource class inventory is not reported
    to the placement service and thus the warnings are noise.

    Change-Id: I342b9b12ec869431c3abad75eb8194c34151a281
    Closes-Bug: #1794773
    (cherry picked from commit 63b9c88386998bc584786ecb8ea7a2aae971a384)

Matt Riedemann (mriedem) on 2019-02-22
Changed in nova:
importance: Undecided → Low

Reviewed: https://review.openstack.org/608611
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e46019a6e52452554b85f5c40a6e4b069172cd9a
Submitter: Zuul
Branch: stable/queens

commit e46019a6e52452554b85f5c40a6e4b069172cd9a
Author: Mark Goddard <email address hidden>
Date: Thu Sep 27 15:32:36 2018 +0100

    Don't emit warning when ironic properties are zero

    If an ironic node is registered without either of the 'memory_mb' or
    'cpus' properties, the following warning messages are seen in the
    nova-compute logs:

    Warning, memory usage is 0 for <instance> on baremetal node <node>.
    Warning, number of cpus is 0 for <instance> on baremetal node <node>.

    As of the Stein release [1], the standard compute resources (VCPU,
    MEMORY_MB, DISK_GB) are not registered with placement for ironic nodes.
    They were not required to be set since the Pike release, but still this
    warning is emitted.

    This change removes these warning messages.

    Backport: rocky, queens, pike

    [1] https://review.openstack.org/#/c/565841/

    NOTE(mriedem): The original commit message on this change incorrectly
    said that [1] was made in Rocky but it was actually made in Stein.
    The important part is that the "memory_mb" and "cpus" properties on
    the node could be 0 since Pike and if they are 0, it just means
    that the related standard resource class inventory is not reported
    to the placement service and thus the warnings are noise.

    Change-Id: I342b9b12ec869431c3abad75eb8194c34151a281
    Closes-Bug: #1794773
    (cherry picked from commit 63b9c88386998bc584786ecb8ea7a2aae971a384)
    (cherry picked from commit 0794345ecd1d61efb7a0d321eb32844d2dd684d0)

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

This issue was fixed in the openstack/nova 17.0.10 release.

This issue was fixed in the openstack/nova 18.2.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers