OpenStack Compute (nova)

ironic: power sync loop makes way too many API calls

Series rocky
Bug #1793556

Bug #1793556 reported by Jim Rollenhagen on 2018-09-20

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Medium	Jim Rollenhagen
	Rocky	Fix Committed	Medium	Jim Rollenhagen

Bug Description

The ironic driver does not use its local cache of node data for the get_info call, which is used during the instance power sync. This results in N API calls per power sync loop, where N is the number of instances managed by the compute service doing the sync.

We should aim to use the cache and reduce this to one or less API calls.

Tags:

OpenStack Infra (hudson-openstack) on 2018-09-20

Changed in nova:
assignee:	nobody → Jim Rollenhagen (jim-rollenhagen)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-21: Fix merged to nova (master)

Reviewed: https://review.openstack.org/602127
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9d5fb1b58e908ccacbbbf29341918d0b0588a36f
Submitter: Zuul
Branch: master

commit 9d5fb1b58e908ccacbbbf29341918d0b0588a36f
Author: Jim Rollenhagen <email address hidden>
Date: Wed Sep 12 12:11:30 2018 -0600

ironic: stop hammering ironic API in power sync loop

Use our node cache to look up the node for an instance, if we have it.
If we can't find it, fall back to hitting ironic's API.

This should be relatively up-to-date info, as it is refreshed on every
resource tracker loop.

Closes-Bug: #1793556
Change-Id: I0069cbc327d952d42dbb8fe54949faab89995a7e

Changed in nova:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-03-04: Fix proposed to nova (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/640771

Matt Riedemann (mriedem) on 2019-03-12

tags:	added: ironic
Changed in nova:
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-03-13: Fix merged to nova (stable/rocky)

Reviewed: https://review.openstack.org/640771
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4ede35281160b8d988ef5b775b97d81950d0c6e1
Submitter: Zuul
Branch: stable/rocky

commit 4ede35281160b8d988ef5b775b97d81950d0c6e1
Author: Jim Rollenhagen <email address hidden>
Date: Wed Sep 12 12:11:30 2018 -0600

ironic: stop hammering ironic API in power sync loop

Use our node cache to look up the node for an instance, if we have it.
If we can't find it, fall back to hitting ironic's API.

This should be relatively up-to-date info, as it is refreshed on every
resource tracker loop.

    Closes-Bug: #1793556
    Change-Id: I0069cbc327d952d42dbb8fe54949faab89995a7e
    (cherry picked from commit 9d5fb1b58e908ccacbbbf29341918d0b0588a36f)