Server operations fail to complete with versioned notifications if payload contains unset is_public field

Bug #1789423 reported by Matt Riedemann on 2018-08-28
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Mohammed Naser
Ocata
Medium
Matt Riedemann
Pike
Medium
Matt Riedemann
Queens
Medium
Matt Riedemann
Rocky
Medium
Matt Riedemann

Bug Description

This is a follow up to bug 1739325 which fixed the scenario that the flavor.disabled field was missing from the embedded instance flavor. The same case occurs for the is_public field, so we should default that to True if it's not set in the embedded instance.flavor.

Matt Riedemann (mriedem) on 2018-08-28
Changed in nova:
importance: Undecided → Medium
status: New → Triaged
Mohammed Naser (mnaser) on 2018-11-02
Changed in nova:
assignee: nobody → Mohammed Naser (mnaser)

Fix proposed to branch: master
Review: https://review.openstack.org/615134

Changed in nova:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/615134
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c4f6b0bf6cc903cf52c4b238c3771604dda174b8
Submitter: Zuul
Branch: master

commit c4f6b0bf6cc903cf52c4b238c3771604dda174b8
Author: Mohammed Naser <email address hidden>
Date: Fri Nov 2 12:21:26 2018 +0100

    Default embedded instance.flavor.is_public attribute

    It is possible that really old instances don't actually have this
    attribute defined which can lead to raising exceptions when loading
    their embedded flavors from the database.

    This patch fixes this by defaulting these values to true if they
    are not set.

    Change-Id: If04cd802ce7184dc94f94804c743faebe0d4bd8c
    Closes-Bug: #1789423

Changed in nova:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/619349
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c689c09996c4a3da9e05ccd5178a4b5060949889
Submitter: Zuul
Branch: stable/rocky

commit c689c09996c4a3da9e05ccd5178a4b5060949889
Author: Mohammed Naser <email address hidden>
Date: Fri Nov 2 12:21:26 2018 +0100

    Default embedded instance.flavor.is_public attribute

    It is possible that really old instances don't actually have this
    attribute defined which can lead to raising exceptions when loading
    their embedded flavors from the database.

    This patch fixes this by defaulting these values to true if they
    are not set.

    Change-Id: If04cd802ce7184dc94f94804c743faebe0d4bd8c
    Closes-Bug: #1789423
    (cherry picked from commit c4f6b0bf6cc903cf52c4b238c3771604dda174b8)

Reviewed: https://review.openstack.org/619351
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=61bf7ae5795a3dfac7afc57bed9b4195cfdb6042
Submitter: Zuul
Branch: stable/queens

commit 61bf7ae5795a3dfac7afc57bed9b4195cfdb6042
Author: Mohammed Naser <email address hidden>
Date: Fri Nov 2 12:21:26 2018 +0100

    Default embedded instance.flavor.is_public attribute

    It is possible that really old instances don't actually have this
    attribute defined which can lead to raising exceptions when loading
    their embedded flavors from the database.

    This patch fixes this by defaulting these values to true if they
    are not set.

    Change-Id: If04cd802ce7184dc94f94804c743faebe0d4bd8c
    Closes-Bug: #1789423
    (cherry picked from commit c4f6b0bf6cc903cf52c4b238c3771604dda174b8)
    (cherry picked from commit c689c09996c4a3da9e05ccd5178a4b5060949889)

This issue was fixed in the openstack/nova 18.1.0 release.

This issue was fixed in the openstack/nova 17.0.9 release.

Reviewed: https://review.openstack.org/619352
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9a0d338c6775803516c5fdb99f0581e40957cb0c
Submitter: Zuul
Branch: stable/pike

commit 9a0d338c6775803516c5fdb99f0581e40957cb0c
Author: Mohammed Naser <email address hidden>
Date: Fri Nov 2 12:21:26 2018 +0100

    Default embedded instance.flavor.is_public attribute

    It is possible that really old instances don't actually have this
    attribute defined which can lead to raising exceptions when loading
    their embedded flavors from the database.

    This patch fixes this by defaulting these values to true if they
    are not set.

    Change-Id: If04cd802ce7184dc94f94804c743faebe0d4bd8c
    Closes-Bug: #1789423
    (cherry picked from commit c4f6b0bf6cc903cf52c4b238c3771604dda174b8)
    (cherry picked from commit c689c09996c4a3da9e05ccd5178a4b5060949889)
    (cherry picked from commit 61bf7ae5795a3dfac7afc57bed9b4195cfdb6042)

Reviewed: https://review.openstack.org/619366
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b8702ded74aad826432dcedaf65535af52835aa5
Submitter: Zuul
Branch: stable/ocata

commit b8702ded74aad826432dcedaf65535af52835aa5
Author: Mohammed Naser <email address hidden>
Date: Fri Nov 2 12:21:26 2018 +0100

    Default embedded instance.flavor.is_public attribute

    It is possible that really old instances don't actually have this
    attribute defined which can lead to raising exceptions when loading
    their embedded flavors from the database.

    This patch fixes this by defaulting these values to true if they
    are not set.

    Change-Id: If04cd802ce7184dc94f94804c743faebe0d4bd8c
    Closes-Bug: #1789423
    (cherry picked from commit c4f6b0bf6cc903cf52c4b238c3771604dda174b8)
    (cherry picked from commit c689c09996c4a3da9e05ccd5178a4b5060949889)
    (cherry picked from commit 61bf7ae5795a3dfac7afc57bed9b4195cfdb6042)
    (cherry picked from commit 9a0d338c6775803516c5fdb99f0581e40957cb0c)

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

This issue was fixed in the openstack/nova 16.1.8 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers