placement api produces many warnings about policy scope check failures

Bug #1786498 reported by Chris Dent on 2018-08-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Matt Riedemann
Rocky
Medium
Matt Riedemann

Bug Description

When oslo policy checks were added to placement, fixtures and functional tests were updated to hide warnings related to scope checks that cannot (yet) work in the way placement is managing policy.

Those some warnings happen with every request on an actually running service. The warnings need to be stifled there too.

Changed in nova:
assignee: Matt Riedemann (mriedem) → Chris Dent (cdent)
Matt Riedemann (mriedem) on 2018-08-10
Changed in nova:
assignee: Chris Dent (cdent) → Matt Riedemann (mriedem)

Reviewed: https://review.openstack.org/590445
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=94617a71761710544cf9505ffda5b6403a645a7e
Submitter: Zuul
Branch: master

commit 94617a71761710544cf9505ffda5b6403a645a7e
Author: Matt Riedemann <email address hidden>
Date: Thu Aug 9 13:32:10 2018 -0400

    placement: ignore policy scope check failures if not enforcing scope

    Rather than spam the placement API logs with scope check
    warnings from oslo.policy when placement isn't configured
    for scope type enforcement, ignore those warnings.

    Note that the same warnings filter in the placement WarningsFixture
    is left intact because the configuration defaults setting code in
    wsgi.py which allows the warning filter to be set in deploy.py,
    is not run by the functional tests. In future changes this will
    be resolved by unifying configuration handling.

    Closes-Bug: #1786498
    Related-Bug: #1784663
    Change-Id: I34e4e550c9c31a654308e555210588156418f9e3

Changed in nova:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/591872
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=97e7087ac329c5b6fc77ddd76d2007e03866e00f
Submitter: Zuul
Branch: stable/rocky

commit 97e7087ac329c5b6fc77ddd76d2007e03866e00f
Author: Matt Riedemann <email address hidden>
Date: Thu Aug 9 13:32:10 2018 -0400

    placement: ignore policy scope check failures if not enforcing scope

    Rather than spam the placement API logs with scope check
    warnings from oslo.policy when placement isn't configured
    for scope type enforcement, ignore those warnings.

    Note that the same warnings filter in the placement WarningsFixture
    is left intact because the configuration defaults setting code in
    wsgi.py which allows the warning filter to be set in deploy.py,
    is not run by the functional tests. In future changes this will
    be resolved by unifying configuration handling.

    Closes-Bug: #1786498
    Related-Bug: #1784663
    Change-Id: I34e4e550c9c31a654308e555210588156418f9e3
    (cherry picked from commit 94617a71761710544cf9505ffda5b6403a645a7e)

This issue was fixed in the openstack/nova 18.0.0.0rc2 release candidate.

Reviewed: https://review.openstack.org/594172
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2b46354d5ab6d59790e69c44bc36a17074155774
Submitter: Zuul
Branch: master

commit 2b46354d5ab6d59790e69c44bc36a17074155774
Author: Chris Dent <email address hidden>
Date: Tue Aug 21 14:23:41 2018 +0100

    Set policy_opt defaults in placement gabbi fixture

    Without this change, tests can intermittently fail with NoSuchOptError
    when a single process does not have other tests running prior to
    gabbi tests. This change ensure the opts are registered and defaulted.

    Change-Id: I1c7e347b6e788928bef96e32c3365d0fdc5ba00f
    Related-Bug: #1786498
    Closes-Bug: #1788176

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers