OpenStack Compute (nova)

Failure during live migration leaves BDM with incorrect connection_info

  1. Series rocky
  2. Bug #1780973
Bug #1780973 reported by Matthew Booth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Lee Yarwood
Queens
Fix Committed
Medium
Lee Yarwood
Rocky
Fix Committed
Medium
Lee Yarwood
Stein
Fix Released
Medium
Lee Yarwood

Bug Description

_rollback_live_migration doesn't restore connection_info.

OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: nobody → Matthew Booth (mbooth-9)
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: Matthew Booth (mbooth-9) → Lee Yarwood (lyarwood)
Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Medium
tags: added: live-migration
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: Lee Yarwood (lyarwood) → Matt Riedemann (mriedem)
Matt Riedemann (mriedem)
Changed in nova:
assignee: Matt Riedemann (mriedem) → Lee Yarwood (lyarwood)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/551349
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1c480a75edc0f5f1b446121491869c02f30437a0
Submitter: Zuul
Branch: master

commit 1c480a75edc0f5f1b446121491869c02f30437a0
Author: Matthew Booth <email address hidden>
Date: Fri Mar 9 18:10:27 2018 +0000

    Restore connection_info after live migration rollback

    Building on I0390c9ff51f49b063f736ca6ef868a4fa782ede5 we can now restore
    the original connection_info for a volume bdm when rolling back after a
    live migration failure.

    Co-Authored-By: Lee Yarwood <email address hidden>
    Closes-Bug: #1780973
    Change-Id: Ic4bbc075127823abfc559693a0db79e5e23f8209

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/660370

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/660375

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/stein)

Reviewed: https://review.opendev.org/660370
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4ff46ff7677530bce3ef268b6a0d85b50308d2fd
Submitter: Zuul
Branch: stable/stein

commit 4ff46ff7677530bce3ef268b6a0d85b50308d2fd
Author: Matthew Booth <email address hidden>
Date: Fri Mar 9 18:10:27 2018 +0000

    Restore connection_info after live migration rollback

    Building on I0390c9ff51f49b063f736ca6ef868a4fa782ede5 we can now restore
    the original connection_info for a volume bdm when rolling back after a
    live migration failure.

    NOTE(lyarwood): Conflict as Ib61913d9d6ef6148170963463bb71c13f4272c5d is
    not present in stable/stein.

    Conflicts:
        nova/compute/manager.py

    Co-Authored-By: Lee Yarwood <email address hidden>
    Closes-Bug: #1780973
    Change-Id: Ic4bbc075127823abfc559693a0db79e5e23f8209
    (cherry picked from commit 1c480a75edc0f5f1b446121491869c02f30437a0)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/662471

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 19.0.1

This issue was fixed in the openstack/nova 19.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/rocky)

Reviewed: https://review.opendev.org/660375
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0c9f98f64fdd845c1a26348418164e55a37042d0
Submitter: Zuul
Branch: stable/rocky

commit 0c9f98f64fdd845c1a26348418164e55a37042d0
Author: Matthew Booth <email address hidden>
Date: Fri Mar 9 18:10:27 2018 +0000

    Restore connection_info after live migration rollback

    Building on I0390c9ff51f49b063f736ca6ef868a4fa782ede5 we can now restore
    the original connection_info for a volume bdm when rolling back after a
    live migration failure.

    NOTE(lyarwood): Conflict as I8da38aec0fe4808273b8587ace3df9dbbc3ab576 is
    not present in stable/rocky.

    Conflicts:
        nova/compute/manager.py

    NOTE(lyarwood): Conflict as Ib61913d9d6ef6148170963463bb71c13f4272c5d is
    not present in stable/stein.

    Conflicts:
        nova/compute/manager.py

    Co-Authored-By: Lee Yarwood <email address hidden>
    Closes-Bug: #1780973
    Change-Id: Ic4bbc075127823abfc559693a0db79e5e23f8209
    (cherry picked from commit 1c480a75edc0f5f1b446121491869c02f30437a0)
    (cherry picked from commit 4ff46ff7677530bce3ef268b6a0d85b50308d2fd)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 18.2.1

This issue was fixed in the openstack/nova 18.2.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/queens)

Reviewed: https://review.opendev.org/662471
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=95a3e0cf6aee8f278a1441f3e50517f08c6f3038
Submitter: Zuul
Branch: stable/queens

commit 95a3e0cf6aee8f278a1441f3e50517f08c6f3038
Author: Matthew Booth <email address hidden>
Date: Fri Mar 9 18:10:27 2018 +0000

    Restore connection_info after live migration rollback

    Building on I0390c9ff51f49b063f736ca6ef868a4fa782ede5 we can now restore
    the original connection_info for a volume bdm when rolling back after a
    live migration failure.

    NOTE(lyarwood): Conflicts as I3689dd6544c387676983be47cf925c3fd7ce72f1
    and Ia9ea1e164fb3b4a386405538eed58d94ad115172 are not present in
    stable/queens.

    Conflicts:
        nova/compute/manager.py
        nova/tests/unit/compute/test_compute_mgr.py

    NOTE(lyarwood): Conflict as I8da38aec0fe4808273b8587ace3df9dbbc3ab576 is
    not present in stable/rocky.

    Conflicts:
        nova/compute/manager.py

    NOTE(lyarwood): Conflict as Ib61913d9d6ef6148170963463bb71c13f4272c5d is
    not present in stable/stein.

    Conflicts:
        nova/compute/manager.py

    Co-Authored-By: Lee Yarwood <email address hidden>
    Closes-Bug: #1780973
    Change-Id: Ic4bbc075127823abfc559693a0db79e5e23f8209
    (cherry picked from commit 1c480a75edc0f5f1b446121491869c02f30437a0)
    (cherry picked from commit 4ff46ff7677530bce3ef268b6a0d85b50308d2fd)
    (cherry picked from commit 0c9f98f64fdd845c1a26348418164e55a37042d0)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.11

This issue was fixed in the openstack/nova 17.0.11 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 20.0.0.0rc1

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.